Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upload trace in Zipkin Lens UI #2350

Closed
zeagord opened this issue Jan 16, 2019 · 5 comments
Closed

Support upload trace in Zipkin Lens UI #2350

zeagord opened this issue Jan 16, 2019 · 5 comments
Assignees
Labels
ui Zipkin UI

Comments

@zeagord
Copy link
Member

zeagord commented Jan 16, 2019

In the legacy UI there is a feature to upload traces and visualise it. We should support the same in the Lens UI

@zeagord zeagord added the ui Zipkin UI label Jan 16, 2019
@tacigar tacigar self-assigned this Jan 21, 2019
@tacigar
Copy link
Member

tacigar commented Feb 1, 2019

To tell the truth, I am wondering whether this function is necessary...
At least I have never used this...
WDYT? @openzipkin/ui

@shakuzen
Copy link
Member

shakuzen commented Feb 1, 2019

Here is the original pull request that added it: #1884

I definitely used it at my previous job and encouraged others to use it. It is one way of getting around the storage period limitation. That is, for a particular interesting trace, you can save it to your local machine or attach it to an issue (e.g. JIRA) so that others can check that trace at any time easily, without having to worry about the original data expiring from the data store. It's a nicer experience than everyone wanting to do this learning how to POST the data to a locally running instance or something.

@codefromthecrypt
Copy link
Member

I concur with tommy's summary

@tacigar
Copy link
Member

tacigar commented Feb 4, 2019

@shakuzen @adriancole
Thank you for your opinions!!!
OK, I see.
I'll implement this feature 🙇

@shakuzen
Copy link
Member

Resolved via #2447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Zipkin UI
Projects
None yet
Development

No branches or pull requests

4 participants