Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending "unknown" as segment name to X-Ray results in incorrect data displayed in the X-Ray UI #87

Closed
robyf opened this issue May 25, 2018 · 1 comment

Comments

@robyf
Copy link
Contributor

robyf commented May 25, 2018

As part of #59 a check has been added that sends "unknown" as segment name to X-Ray when the received span doesn't have a remote service name. This solves the issue that X-Ray segments must have a name but creates issues on the X-Ray side, for example:
selection_007
in this case the "unknown" segment belongs to the security-gateway-aws service and not to the test-app and in the service map "unknown" services appear as dependencies:
selection_008

@codefromthecrypt
Copy link
Member

Thanks for all the help

closed via 07d46d2 for now and https://docs.google.com/document/d/1ZFg2SX2DUJFRE8MpodV9DL9uYgNHe-90PMQIb1DrY8k/edit#

we can revisit as experience gains or alternate approaches become possible. For example adjusters on the collector side and whatnot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants