Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zimdump does not dump redirects properly (empty files) #23

Closed
sharun-s opened this issue Sep 18, 2018 · 1 comment · Fixed by #80
Closed

zimdump does not dump redirects properly (empty files) #23

sharun-s opened this issue Sep 18, 2018 · 1 comment · Fixed by #80
Assignees
Labels
bug good first issue IPFS Necessary for proper IPFS version of Wikipedia zimdump

Comments

@sharun-s
Copy link

sharun-s commented Sep 18, 2018

zimdump -v -D ray wikipedia_en_ray_charles_2015-06.zim

In the ray directory, to see all the files created of size 0
find ray -size 0c

Looks like this is not the intended use case, but I ran into issues when I tried to use zimdump+zimwriterfs to make some fixes and regenerate the ray charles zim openzim/zimwriterfs#80. All the empty files turned into inode/x-empty direntries in the generated zim. Maybe in future, a process is possible where zimdump generates the "redirects tsv file" that zimwriterfs can consume to recreate redirect specific info.

@kelson42 kelson42 changed the title zimdump generates a bunch of empty files corresponding to redirects zimdump does not dump redirects properly (empty files) Sep 18, 2018
@kelson42
Copy link
Contributor

I think zimdump should probably create an HTML file with this header:

<meta http-equiv="refresh" content="0; url=http://example.com/" />

@kelson42 kelson42 added the IPFS Necessary for proper IPFS version of Wikipedia label Nov 9, 2019
@MiguelRocha MiguelRocha linked a pull request Apr 3, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue IPFS Necessary for proper IPFS version of Wikipedia zimdump
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants