Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make asm-x86_64/atomic.S build on FreeBSD #9634

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

mattmacy
Copy link
Contributor

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #9634 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #9634     +/-   ##
=========================================
- Coverage   79.37%   79.28%   -0.1%     
=========================================
  Files         418      418             
  Lines      123531   123531             
=========================================
- Hits        98057    97943    -114     
- Misses      25474    25588    +114
Flag Coverage Δ
#kernel 79.86% <ø> (-0.06%) ⬇️
#user 66.93% <ø> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c46813...2865396. Read the comment docs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 27, 2019
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 27, 2019
@behlendorf behlendorf requested a review from lundman November 27, 2019 22:43
Copy link
Contributor

@lundman lundman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me, but the asmlinkage.h file comes back a lot with the fletcher/raidz vectorized code (similarly simd_x86.h), perhaps we could consider a spl/include file we use universally, which lives in platform directory. Or not, only like 5 of them, guess I remember it worse :)

@behlendorf
Copy link
Contributor

behlendorf commented Nov 28, 2019

perhaps we could consider a spl/include file we use universally

Sounds like a good idea to me. There's a lot of stuff in the asm_linkage.h we pulled from illumos and might be nice to to trim it down to what's actually needed. But I think we should leave that for a future PR.

@behlendorf behlendorf merged commit c54687c into openzfs:master Nov 30, 2019
@mattmacy mattmacy deleted the projects/atomic_s branch December 19, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants