initrd script is broken if /bin/plymouth exists on system

[runderwo]

System information

Type	Version/Name
Distribution Name	Debian
Distribution Version	stretch-backports
Linux Kernel	4.19.0-0.bpo.1-amd64
Architecture	amd64
ZFS Version	0.8.0~rc2-0-0
SPL Version	0.8.0~rc2-0-0

Describe the problem you're observing

I apologize for not having a screenshot of this, but if /bin/plymouth exists and the initramfs script uses it to get the password from the console to decrypt an encrypted dataset containing the root filesystem, the zfs load-key command then fails because of the single quotes surrounding the encrypted dataset in the zfs command that is fed to plymouth.

Describe how to reproduce the problem

Install plymouth, create a initramfs, and try to decrypt an encrypted dataset containing the root filesystem at boot.

Include any warning/errors/backtraces from the system logs

[ghfields]

Background:
Single quotes were added midway through pull request because of review comments (those comments seem decimated by github):
#8093 (comment)

It was also mirrored in dracut: #8114

As that pull states... it was intended not break pools with spaces in their names.

[runderwo]

To be clear, I am not at all recommending that the quotes be removed, but rather if plymouth support is important, that the command string be passed through to plymouth ask-for-password in a way that has correct semantics. Plymouth support is actually not important to me; I removed it from the system once I realized what was going wrong in the initrd.

[runderwo]

https://packages.debian.org/stretch/plymouth - up to date system

[rlaager]

This should be fixed by #9202.