Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm/generic/zfs.spec.in ignores --with-dracutdir from ./configure #1680

Closed
LnxGnome opened this issue Aug 27, 2013 · 3 comments
Closed

rpm/generic/zfs.spec.in ignores --with-dracutdir from ./configure #1680

LnxGnome opened this issue Aug 27, 2013 · 3 comments
Labels
Type: Building Indicates an issue related to building binaries
Milestone

Comments

@LnxGnome
Copy link

Suggested fix:

--- zfs-0.6.2/rpm/generic/zfs.spec.in.old 2013-08-22 17:11:06.000000000 -0400
+++ zfs-0.6.2/rpm/generic/zfs.spec.in 2013-08-26 21:15:00.535887599 -0400
@@ -5,7 +5,7 @@
%global _dracutdir %{_prefix}/lib/dracut
%else
%global _udevdir /lib/udev
-%global _dracutdir /lib/dracut
+%global _dracutdir @dracutdir@
%endif

%bcond_with debug

@behlendorf
Copy link
Contributor

The ./configure result is actually ignored here on purpose. When building packages the expectation is that the spec file will pass to configure the right place to install this for the distribution. Ideally, the distribution would provide us an rpmmacro for dracut but that's sadly not the case.

@FransUrbo
Copy link
Contributor

Related to #2310, with fix in #2312. @behlendorf Could you tag this 0.6.3 and close it at the same time as the two mentioned?

@behlendorf
Copy link
Contributor

@FransUrbo Yes, thanks for noticing this. I'll close it out when I merged the related fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Building Indicates an issue related to building binaries
Projects
None yet
Development

No branches or pull requests

3 participants