FTBFS zfs-2.1.4 i586 ppc64le

[jengelh]

i586
[  137s] /home/abuild/rpmbuild/BUILD/obj-default/include/os/linux/kernel/linux/simd_x86.h:154:2: error: #error "Toolchain needs to support the XSAVE assembler instruction"
[  137s]   154 | #error "Toolchain needs to support the XSAVE assembler instruction"

ppc64le
…rpmbuild/BUILD/obj-default/module/Module.symvers -e -i Module.symvers    -T -
[  249s] ERROR: modpost: GPL-incompatible module zfs.ko uses GPL-only symbol 'mmu_feature_keys'
[  249s] make[4]: *** [/usr/src/linux-5.17.1-1/scripts/Makefile.modpost:140: /home/abuild/rpmbuild/BUILD/obj-default/module/Module.symvers] Error 1
[  249s] make[4]: *** Deleting file '/home/abuild/rpmbuild/BUILD/obj-default/module/Module.symvers'
[  249s] make[3]: *** [../../../linux-5.17.1-1/Makefile:1760: modules] Error 2
[  249s] make[3]: Leaving directory '/usr/src/linux-5.17.1-1-obj/ppc64le/default'

[AttilaFueloep]

Unfortunately there's more information needed regarding the XSAVE build failure. What toolchain at what version are you using?
What is the CPU model? What distro are you building on? Could you give the cc line leading to this?

Regarding ppc64, see #12590.

[AttilaFueloep]

Sorry, just realized this is about the original P5 from 20 years ago, so this must be some embedded system I'd guess. It didn't occur to me that there would be a need to run OpenZFS on such a system. I'm going to open a PR with a fix for the build failure. The fix will assume that the toolchain supports the FXSAVE instruction, can you confirm that this assumption is correct?

[rincebrain]

The ppc64le thing is #12590 - Ubuntu wrote a patch to work around it, though that patch may break other things on older OpenZFS releases according to someone I know who tried running it.

[jengelh]

$ echo 'xsave (%ecx)' >x.s
$ gcc -c x.s -m32
$ objdump -d x.o

x.o:     file format elf32-i386


Disassembly of section .text:

00000000 <.text>:
   0:   0f ae 21                xsave  (%ecx)

[jengelh]

GNU ld (GNU Binutils; openSUSE Tumbleweed) 2.38.20220304-3
gcc version 11.2.1 20220316 [revision 6a1150d1524aeda3381b2171712e1a6611d441d6] (SUSE Linux)

[jengelh]

The fix will assume that the toolchain supports the FXSAVE instruction, can you confirm that this assumption is correct?

Given FXSAVE was specified for x87, every toolchain ought to have it.

[szubersk]

@jengelh would you mind confirming if #13367 solved the compilation issue for you?

[AttilaFueloep]

@jengelh Regarding the XSAVE issue, I've prepared a fix months ago which unfortunately slipped through the cracks, sorry for that. Let me dig out the workspace with that fix an open a PR.