Skip to content
This repository was archived by the owner on Feb 26, 2020. It is now read-only.

track changes to the arguments to fop fsync() (kernel v2.6.34-8258-g7ea8085) #20

Closed
sehe opened this issue Jul 6, 2010 · 2 comments
Closed

Comments

@sehe
Copy link

sehe commented Jul 6, 2010

From 56c5c6071588f236deb11d5822d6a0bb66b2cdea Mon Sep 17 00:00:00 2001
From: Seth Heeren 
Date: Tue, 6 Jul 2010 17:02:06 +0200
Subject: [PATCH] track changes to the arguments to fop fsync()

The file operation fsync dropped an unused struct dentry parameter

---
 module/spl/spl-debug.c |    2 +-
 module/spl/spl-vnode.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/module/spl/spl-debug.c b/module/spl/spl-debug.c
index 6a10862..e38b0fd 100644
--- a/module/spl/spl-debug.c
+++ b/module/spl/spl-debug.c
@@ -920,7 +920,7 @@ trace_filp_open (const char *name, int flags, int mode, int *err)
 }
 
 #define trace_filp_write(fp, b, s, p)  (fp)->f_op->write((fp), (b), (s), p)
-#define trace_filp_fsync(fp)           (fp)->f_op->fsync((fp),(fp)->f_dentry,1)
+#define trace_filp_fsync(fp)           (fp)->f_op->fsync((fp),1)
 #define trace_filp_close(f)            filp_close(f, NULL)
 #define trace_filp_poff(f)             (&(f)->f_pos)
 
diff --git a/module/spl/spl-vnode.c b/module/spl/spl-vnode.c
index b5c34fb..d9aff85 100644
--- a/module/spl/spl-vnode.c
+++ b/module/spl/spl-vnode.c
@@ -473,7 +473,7 @@ int vn_fsync(vnode_t *vp, int flags, void *x3, void *x4)
    if (flags & FDSYNC)
        datasync = 1;
 
-   RETURN(-file_fsync(vp->v_file, vp->v_file->f_dentry, datasync));
+   RETURN(-file_fsync(vp->v_file, datasync));
 } /* vn_fsync() */
 EXPORT_SYMBOL(vn_fsync);
 
-- 
1.7.0.4
@behlendorf
Copy link
Contributor

Linux 2.6.35 compat change fixed by commit f0ff89f.

@sehe
Copy link
Author

sehe commented Jul 14, 2010

Great. Good to see that you have found the automake-fu to solve this elegantly :)

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants