Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Commit

Permalink
32-bit compat, hostid_read()
Browse files Browse the repository at this point in the history 
Explicitly cast the sizeof in hostid_read() to prevent the
following compiler warning on 32-bit systems.

  module/spl/spl-generic.c:490:10: error: format '%lu' expects
  argument of type 'long unsigned int', but argument 4 has type
  'unsigned int' [-Werror=format]

Signed-off-by: Brian Behlendorf <[email protected]>
  • Loading branch information
@behlendorf
behlendorf committed Jul 20, 2012
1 parent d503b97 commit e8267ac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions module/spl/spl-generic.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,8 @@ hostid_read(void)
if (size < sizeof(HW_HOSTID_MASK)) {
printk(KERN_WARNING
"SPL: Ignoring the %s file because it is %llu bytes; "
"expecting %lu bytes instead.\n",
spl_hostid_path, size, sizeof(HW_HOSTID_MASK));
"expecting %lu bytes instead.\n", spl_hostid_path,
size, (unsigned long)sizeof(HW_HOSTID_MASK));
kobj_close_file(file);
return -3;
}
Expand Down

6 comments on commit e8267ac

@Rudd-O
Copy link

@Rudd-O Rudd-O commented on e8267ac Jul 23, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit produces the following error:

~/Projects/Mine/[email protected] α:
git clean -fxd && git reset --hard && ./autogen.sh && ./configure && make
Removing Makefile
Removing PKGBUILD-spl
Removing PKGBUILD-spl-modules
Removing cmd/.deps/
Removing cmd/.libs/
Removing cmd/Makefile
Removing cmd/spl
Removing cmd/spl.o
Removing cmd/splat
Removing cmd/splat.o
Removing config.log
Removing config.status
Removing include/Makefile
Removing lib/.deps/
Removing lib/.libs/
Removing lib/Makefile
Removing lib/libcommon.la
Removing lib/list.lo
Removing lib/list.o
Removing libtool
Removing module/.tmp_versions/
Removing module/Makefile
Removing module/Module.symvers
Removing module/modules.order
Removing module/spl/.spl-atomic.o.cmd
Removing module/spl/.spl-condvar.o.cmd
Removing module/spl/.spl-cred.o.cmd
Removing module/spl/.spl-debug.o.cmd
Removing module/spl/.spl-err.o.cmd
Removing module/spl/.spl-generic.o.cmd
Removing module/spl/.spl-kmem.o.cmd
Removing module/spl/.spl-kobj.o.cmd
Removing module/spl/.spl-kstat.o.cmd
Removing module/spl/.spl-mutex.o.cmd
Removing module/spl/.spl-proc.o.cmd
Removing module/spl/.spl-rwlock.o.cmd
Removing module/spl/.spl-taskq.o.cmd
Removing module/spl/.spl-thread.o.cmd
Removing module/spl/.spl-time.o.cmd
Removing module/spl/.spl-tsd.o.cmd
Removing module/spl/.spl-vnode.o.cmd
Removing module/spl/.spl-xdr.o.cmd
Removing module/spl/.spl-zlib.o.cmd
Removing module/spl/.spl.ko.cmd
Removing module/spl/.spl.mod.o.cmd
Removing module/spl/.spl.o.cmd
Removing module/spl/Makefile
Removing module/spl/modules.order
Removing module/spl/spl-atomic.o
Removing module/spl/spl-condvar.o
Removing module/spl/spl-cred.o
Removing module/spl/spl-debug.o
Removing module/spl/spl-err.o
Removing module/spl/spl-generic.o
Removing module/spl/spl-kmem.o
Removing module/spl/spl-kobj.o
Removing module/spl/spl-kstat.o
Removing module/spl/spl-mutex.o
Removing module/spl/spl-proc.o
Removing module/spl/spl-rwlock.o
Removing module/spl/spl-taskq.o
Removing module/spl/spl-thread.o
Removing module/spl/spl-time.o
Removing module/spl/spl-tsd.o
Removing module/spl/spl-vnode.o
Removing module/spl/spl-xdr.o
Removing module/spl/spl-zlib.o
Removing module/spl/spl.ko
Removing module/spl/spl.mod.c
Removing module/spl/spl.mod.o
Removing module/spl/spl.o
Removing module/splat/.splat-atomic.o.cmd
Removing module/splat/.splat-condvar.o.cmd
Removing module/splat/.splat-cred.o.cmd
Removing module/splat/.splat-ctl.o.cmd
Removing module/splat/.splat-generic.o.cmd
Removing module/splat/.splat-kmem.o.cmd
Removing module/splat/.splat-kobj.o.cmd
Removing module/splat/.splat-linux.o.cmd
Removing module/splat/.splat-list.o.cmd
Removing module/splat/.splat-mutex.o.cmd
Removing module/splat/.splat-random.o.cmd
Removing module/splat/.splat-rwlock.o.cmd
Removing module/splat/.splat-taskq.o.cmd
Removing module/splat/.splat-thread.o.cmd
Removing module/splat/.splat-time.o.cmd
Removing module/splat/.splat-vnode.o.cmd
Removing module/splat/.splat-zlib.o.cmd
Removing module/splat/.splat.o.cmd
Removing module/splat/Makefile
Removing module/splat/modules.order
Removing module/splat/splat-atomic.o
Removing module/splat/splat-condvar.o
Removing module/splat/splat-cred.o
Removing module/splat/splat-ctl.o
Removing module/splat/splat-generic.o
Removing module/splat/splat-kmem.o
Removing module/splat/splat-kobj.o
Removing module/splat/splat-linux.o
Removing module/splat/splat-list.o
Removing module/splat/splat-mutex.o
Removing module/splat/splat-random.o
Removing module/splat/splat-rwlock.o
Removing module/splat/splat-taskq.o
Removing module/splat/splat-thread.o
Removing module/splat/splat-time.o
Removing module/splat/splat-vnode.o
Removing module/splat/splat-zlib.o
Removing module/splat/splat.o
Removing scripts/Makefile
Removing spl-modules.spec
Removing spl.release
Removing spl.spec
Removing spl_config.h
Removing spl_config.h.in~
Removing stamp-h1
HEAD is now at e8267ac 32-bit compat, hostid_read()
checking metadata... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking whether to enable maintainer-specific portions of Makefiles... no
checking whether make supports nested variables... yes
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking spl license... GPL
checking linux distribution... fedora
checking default package type... rpm
checking whether rpm is available... yes (4.9.1.3)
checking whether rpmbuild is available... yes (4.9.1.3)
checking whether dpkg is available... no
checking whether dpkg-buildpackage is available... no
checking whether alien is available... no
checking spl config... all
checking kernel source directory... /usr/src/kernels/3.4.4-5.fc17.x86_64
checking kernel build directory... /usr/src/kernels/3.4.4-5.fc17.x86_64
checking kernel source version... 3.4.4-5.fc17.x86_64
checking kernel file name for module symbols... Module.symvers
checking whether Linux was built with CONFIG_PREEMPT... no
checking whether debugging is enabled... no
checking whether basic debug logging is enabled... yes
checking whether basic kmem accounting is enabled... yes
checking whether detailed kmem tracking is enabled... no
checking whether atomic types use spinlocks... no
checking whether kernel defines atomic64_t... yes
checking whether kernel defines atomic64_cmpxchg... no
checking whether kernel defines atomic64_xchg... yes
checking whether kernel defines uintptr_t... yes
checking whether INIT_WORK wants 3 args... no
checking whether register_sysctl_table() wants 2 args... no
checking whether set_shrinker() available... no
checking whether shrinker callback wants 3 args... no
checking whether struct path used in struct nameidata... yes
checking whether symbol task_curr is exported... no
checking whether unnumbered sysctl support exists... no
checking whether struct ctl_table has ctl_name... no
checking whether fls64() is available... yes
checking whether symbol device_create is exported... yes
checking whether device_create() wants 5 args... yes
checking whether symbol class_device_create is exported... no
checking whether symbol set_normalized_timespec is exported... yes
checking whether set_normalized_timespec() is an inline... yes
checking whether timespec_sub() is available... yes
checking whether init_utsname() is available... yes
checking whether header linux/fdtable.h exists... yes
checking whether files_fdtable() is available... yes
checking whether __clear_close_on_exec() is available... yes
checking whether header linux/uaccess.h exists... yes
checking whether kmalloc_node() is available... yes
checking whether symbol monotonic_clock is exported... no
checking whether struct inode has i_mutex... yes
checking whether struct mutex has owner... yes
checking whether struct mutex owner is a task_struct... yes
checking whether mutex_lock_nested() is available... yes
checking whether on_each_cpu() wants 3 args... yes
checking whether symbol kallsyms_lookup_name is exported... yes
checking whether symbol get_vmalloc_info is exported... no
checking whether symbol *_pgdat exist... yes
checking whether symbol first_online_pgdat is exported... no
checking whether symbol next_online_pgdat is exported... no
checking whether symbol next_zone is exported... no
checking whether symbol pgdat_list is exported... no
checking whether global_page_state() is available... yes
checking whether page state NR_FREE_PAGES is available... yes
checking whether page state NR_INACTIVE is available... no
checking whether page state NR_INACTIVE_ANON is available... yes
checking whether page state NR_INACTIVE_FILE is available... yes
checking whether page state NR_ACTIVE is available... no
checking whether page state NR_ACTIVE_ANON is available... yes
checking whether page state NR_ACTIVE_FILE is available... yes
checking whether symbol get_zone_counts is needed... no
checking whether symbol user_path_at is exported... yes
checking whether symbol set_fs_pwd is exported... no
checking whether set_fs_pwd() wants 2 args... yes
checking whether vfs_unlink() wants 2 args... yes
checking whether vfs_rename() wants 4 args... yes
checking whether symbol vfs_fsync is exported... yes
checking whether vfs_fsync() wants 2 args... yes
checking whether struct fs_struct uses spinlock_t... yes
checking whether struct cred exists... yes
checking whether symbol groups_search is exported... no
checking whether symbol __put_task_struct is exported... yes
checking whether proc_handler() wants 5 args... yes
checking whether symbol kvasprintf is exported... yes
checking whether symbol rwsem_is_locked is exported... no
checking whether symbol invalidate_inodes is exported... no
checking whether symbol invalidate_inodes_check is exported... no
checking whether invalidate_inodes() wants 2 args... yes
checking whether symbol shrink_dcache_memory is exported... no
checking whether symbol shrink_icache_memory is exported... no
checking whether symbol kern_path_parent exists in header... yes
checking whether symbol kern_path_parent is exported... no
checking whether zlib_deflate_workspacesize() wants 2 args... yes
checking whether struct shrink_control exists... yes
checking whether struct rw_semaphore member wait_lock is raw... yes
checking whether pmd_alloc_with_mask exists... no
configure: creating ./config.status
config.status: creating Makefile
config.status: creating lib/Makefile
config.status: creating cmd/Makefile
config.status: creating module/Makefile
config.status: creating module/spl/Makefile
config.status: creating module/splat/Makefile
config.status: creating include/Makefile
config.status: creating scripts/Makefile
config.status: creating spl.spec
config.status: creating spl-modules.spec
config.status: creating PKGBUILD-spl
config.status: creating PKGBUILD-spl-modules
config.status: creating spl.release
config.status: creating spl_config.h
config.status: executing depfiles commands
config.status: executing libtool commands
make  all-recursive
make[1]: Entering directory `/home/rudd-o/Projects/Mine/spl'
Making all in lib
make[2]: Entering directory `/home/rudd-o/Projects/Mine/spl/lib'
/bin/sh ../libtool  --tag=CC --silent  --mode=compile gcc -DHAVE_CONFIG_H -include ../spl_config.h    -Wall -Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -g -O2 -MT list.lo -MD -MP -MF .deps/list.Tpo -c -o list.lo list.c
mv -f .deps/list.Tpo .deps/list.Plo
/bin/sh ../libtool  --tag=CC --silent  --mode=link gcc -Wall -Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -g -O2   -o libcommon.la  list.lo  
make[2]: Leaving directory `/home/rudd-o/Projects/Mine/spl/lib'
Making all in cmd
make[2]: Entering directory `/home/rudd-o/Projects/Mine/spl/cmd'
gcc -DHAVE_CONFIG_H -include ../spl_config.h -I../lib    -Wall -Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -g -O2 -MT spl.o -MD -MP -MF .deps/spl.Tpo -c -o spl.o spl.c
mv -f .deps/spl.Tpo .deps/spl.Po
/bin/sh ../libtool  --tag=CC --silent  --mode=link gcc -Wall -Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -g -O2   -o spl spl.o  
gcc -DHAVE_CONFIG_H -include ../spl_config.h -I../lib    -Wall -Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -g -O2 -MT splat.o -MD -MP -MF .deps/splat.Tpo -c -o splat.o splat.c
mv -f .deps/splat.Tpo .deps/splat.Po
/bin/sh ../libtool  --tag=CC --silent  --mode=link gcc -Wall -Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -g -O2 ../lib/libcommon.la  -o splat splat.o  
make[2]: Leaving directory `/home/rudd-o/Projects/Mine/spl/cmd'
Making all in scripts
make[2]: Entering directory `/home/rudd-o/Projects/Mine/spl/scripts'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/home/rudd-o/Projects/Mine/spl/scripts'
Making all in module
make[2]: Entering directory `/home/rudd-o/Projects/Mine/spl/module'
make -C /usr/src/kernels/3.4.4-5.fc17.x86_64 SUBDIRS=`pwd`  modules
make[3]: Entering directory `/usr/src/kernels/3.4.4-5.fc17.x86_64'
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-debug.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-proc.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-kmem.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-thread.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-taskq.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-rwlock.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-vnode.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-err.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-time.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-kobj.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-generic.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-atomic.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-mutex.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-kstat.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-condvar.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-xdr.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-cred.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-tsd.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/spl/../../module/spl/spl-zlib.o
  LD [M]  /home/rudd-o/Projects/Mine/spl/module/spl/spl.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-ctl.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-kmem.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-taskq.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-random.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-mutex.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-condvar.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-thread.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-rwlock.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-time.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-vnode.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-kobj.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-atomic.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-list.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-generic.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-cred.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-zlib.o
  CC [M]  /home/rudd-o/Projects/Mine/spl/module/splat/../../module/splat/splat-linux.o
  LD [M]  /home/rudd-o/Projects/Mine/spl/module/splat/splat.o
  Building modules, stage 2.
/usr/src/kernels/3.4.4-5.fc17.x86_64/scripts/Makefile.modpost:113: target `/home/rudd-o/Projects/Mine/spl/module/.tmp_versions/splat.mod' doesn't match the target pattern
/usr/src/kernels/3.4.4-5.fc17.x86_64/scripts/Makefile.modpost:114: warning: overriding recipe for target `/home/rudd-o/Projects/Mine/spl/module/.tmp_versions/splat.mod'
/usr/src/kernels/3.4.4-5.fc17.x86_64/scripts/Makefile.modpost:101: warning: ignoring old recipe for target `/home/rudd-o/Projects/Mine/spl/module/.tmp_versions/splat.mod'
/usr/src/kernels/3.4.4-5.fc17.x86_64/scripts/Makefile.modpost:124: target `/home/rudd-o/Projects/Mine/spl/module/.tmp_versions/splat.mod' doesn't match the target pattern
/usr/src/kernels/3.4.4-5.fc17.x86_64/scripts/Makefile.modpost:125: warning: overriding recipe for target `/home/rudd-o/Projects/Mine/spl/module/.tmp_versions/splat.mod'
/usr/src/kernels/3.4.4-5.fc17.x86_64/scripts/Makefile.modpost:114: warning: ignoring old recipe for target `/home/rudd-o/Projects/Mine/spl/module/.tmp_versions/splat.mod'
make[4]: Circular /home/rudd-o/Projects/Mine/spl/module/.tmp_versions/splat.mod <- __modpost dependency dropped.
  MODPOST 2 modules
  CC      /home/rudd-o/Projects/Mine/spl/module/spl/spl.mod.o
  LD [M]  /home/rudd-o/Projects/Mine/spl/module/spl/spl.ko
make[3]: Leaving directory `/usr/src/kernels/3.4.4-5.fc17.x86_64'
make[2]: Leaving directory `/home/rudd-o/Projects/Mine/spl/module'
Making all in include
make[2]: Entering directory `/home/rudd-o/Projects/Mine/spl/include'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/home/rudd-o/Projects/Mine/spl/include'
make[2]: Entering directory `/home/rudd-o/Projects/Mine/spl'
make[2]: Nothing to be done for `all-am'.
make[2]: Leaving directory `/home/rudd-o/Projects/Mine/spl'
make[1]: Leaving directory `/home/rudd-o/Projects/Mine/spl'

@Rudd-O
Copy link

@Rudd-O Rudd-O commented on e8267ac Jul 23, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this happens to me with the parent commit too.

I don't know what is wrong.

@Rudd-O
Copy link

@Rudd-O Rudd-O commented on e8267ac Jul 23, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens with all commits to the extent that I know. Behavior started happening, to the best of my knowledge, after a Fedora package update.

@prakashsurya
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just installed a fresh FC17 in a VM and am not seeing the errors you described above.

@Rudd-O
Copy link

@Rudd-O Rudd-O commented on e8267ac Jul 24, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what the problem is. The problem is only when the spl sources I'm compiling are stored on a ZFS dataset. The problem does not happen if the file system where the spl checkout is, is an ext4 or a tmpfs file system.

Weird, huh?

@behlendorf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a hunch this is related to issue openzfs/zfs#764 which we really need to fix. Currently inodes may be a bit to lazily updated in zfs which can confuse certain utilities.

Please sign in to comment.