Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] fix make lint bug #698

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

Congrool
Copy link
Member

@Congrool Congrool commented Dec 28, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix some bugs when make lint:

  1. GOBIN is defined nowhere, so when we make lint with no golangci-lint installed, the shell will run /golangci-lint and result in error.
  2. golangci-lint install command bug
  3. gofmt some files to enable make lint to support go 1.17 or later version

Since go 1.17, it will transition from // +build: to //go:build to do conditional compilation. Thus, when make lint with go 1.17 or later version, it will end in gofmt error.
More Info: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix some bugs when make lint:

  1. GOBIN is defined nowhere, so when we make lint with no golangci-lint installed, the shell will run /golangci-lint` and result in error.
  2. golangci-lint install command bug
  3. gofmt some files to enable make lint to support go 1.17 or later version

Since go 1.17, it will transition from // +build: to //go:build to do conditional compilation. Thus, when make lint with go 1.17 or later, it will end in gofmt error.
More Info: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Dec 28, 2021
@openyurt-bot openyurt-bot merged commit 354620d into openyurtio:master Dec 28, 2021
@Congrool Congrool deleted the makelint branch December 28, 2021 07:52
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants