Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull yurt-tunnel-server image when IfNotPresent #512

Merged
merged 1 commit into from
Sep 30, 2021
Merged

pull yurt-tunnel-server image when IfNotPresent #512

merged 1 commit into from
Sep 30, 2021

Conversation

Congrool
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

To avoid using different version of yurt-tunnel-agent and yurt-tunnel-server.

Which issue(s) this PR fixes:

Fixes #511

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

To avoid using different version of yurt-tunnel-agent and yurt-tunnel-server.

Which issue(s) this PR fixes:

Fixes #511

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Sep 30, 2021
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Sep 30, 2021
@rambohe-ch
Copy link
Member

rambohe-ch commented Sep 30, 2021 •
edited
Loading

@Congrool how about update imagePullPolicy of config/setup/yurt-tunnel-server.yaml and config/yaml-template/yurt-tunnel-server.yaml at the same time?

@Congrool
Copy link
Member Author

@Congrool how about update imagePullPolicy of config/setup/yurt-tunnel-server.yaml and config/yaml-template/yurt-tunnel-server.yaml at the same time?

Sure, I'll do it.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added lgtm lgtm approved approved labels Sep 30, 2021
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit e6b8b00 into openyurtio:master Sep 30, 2021
@Congrool Congrool mentioned this pull request Oct 13, 2021
Closed
6 tasks
@Congrool Congrool deleted the imagepull branch December 27, 2021 10:12
@Congrool Congrool mentioned this pull request Jan 26, 2022
Merged
6 tasks
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@rambohe-ch
Merge pull request openyurtio#512 from Congrool/imagepull
5b68ff2 
pull yurt-tunnel-server image when IfNotPresent
@nelzhang02184516 nelzhang02184516 mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@Peeknut Peeknut Awaiting requested review from Peeknut

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]Avoid using different version of yurt-tunnel-agent and yurt-tunnel-server, when deploying with yurtctl
3 participants
@Congrool @openyurt-bot @rambohe-ch