Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] yurtctl revert should delete cm yurt-tunnel-nodes #531

Closed
Congrool opened this issue Oct 24, 2021 · 3 comments · Fixed by #540
Closed

[BUG] yurtctl revert should delete cm yurt-tunnel-nodes #531

Congrool opened this issue Oct 24, 2021 · 3 comments · Fixed by #540
Assignees
Labels
kind/bug kind/bug

Comments

@Congrool
Copy link
Member

What happened:
When using yurtctl revert to revert the yurt cluster back to a kubernetes cluster, it seems that it will not delete the configmap yurt-tunnel-nodes which is used by yurt-tunnel to resolve dns.
We can find the configmap yurt-tunnel-nodes after reversion.

root@openyurt-e2e-test-control-plane:~/openyurt# kubectl get cm -A
NAMESPACE            NAME                                 DATA   AGE
default              kube-root-ca.crt                     1      50m
kube-node-lease      kube-root-ca.crt                     1      50m
kube-public          cluster-info                         2      50m
kube-public          kube-root-ca.crt                     1      50m
kube-system          coredns                              1      50m
kube-system          extension-apiserver-authentication   6      50m
kube-system          kube-proxy                           2      50m
kube-system          kube-root-ca.crt                     1      50m
kube-system          kubeadm-config                       2      50m
kube-system          kubelet-config-1.20                  1      50m
kube-system          yurt-tunnel-nodes                    1      43m
kube-system          yurtctl-lock                         0      46m
local-path-storage   kube-root-ca.crt                     1      50m
local-path-storage   local-path-config                    1      50m

What you expected to happen:
yurtctl should delete yurt-tunnel-nodes when yurt-tunnel has been deployed through yurtctl convert --deploy-yurttunnel

How to reproduce it (as minimally and precisely as possible):
Use yurtctl convert --deploy-yurttunnel to convert the k8s cluster to openyurt cluster and then use yurtctl revert to revert it back to the k8s cluster.

others
We can also find configmap yurtctl-lock left in the cluster. Does it need to be deleted as well?

/kind bug

@Congrool Congrool added the kind/bug kind/bug label Oct 24, 2021
@rambohe-ch
Copy link
Member

@Congrool Thank you for raising issue.
I think these two configmaps should be removed after yurtctl revert, would you like to take over and fix this bug?

@Congrool
Copy link
Member Author

@Congrool Thank you for raising issue. I think these two configmaps should be removed after yurtctl revert, would you like to take over and fix this bug?

Sure.

@rambohe-ch
Copy link
Member

/assign @Congrool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants