Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device better ways to link examples to an op specification #36

Closed
sdasgup3 opened this issue Aug 24, 2022 · 2 comments · Fixed by #155
Closed

Device better ways to link examples to an op specification #36

sdasgup3 opened this issue Aug 24, 2022 · 2 comments · Fixed by #155
Assignees

Comments

@sdasgup3
Copy link
Member

Request description

Currently, the spec inline examples, demonstrating the working of an op, as follows:

// %x: [[1, 2], [3, 4]]
// %y: [[5, 6], [7, 8]]
%z = stablehlo.add %x, %y : tensor<2x2xf32>
// %z: [[6, 8], [10, 12]]

In the near future, let's think about the best way of providing these examples. For example, can we just link to the interpreter implementation of the op, so that people can check out the test suite? Or, more generally, let's rename this section to "Implementation" and link to the source code?

Additional context

No response

@sdasgup3 sdasgup3 self-assigned this Aug 24, 2022
@sdasgup3 sdasgup3 added the Spec label Sep 2, 2022
@sdasgup3
Copy link
Member Author

sdasgup3 commented Sep 7, 2022

Once we have a couple of op implementations + tests ready, we will start adding links of corresponding test files in the spec

@sdasgup3
Copy link
Member Author

No progress last week. I am planning to address this by the end of this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant