[WIP] Conda install openwpm dependencies #429
Conversation
…Firefox's headless mode.
…into conda-install-openwpm-dependencies
That was easy!
* need to test scripts on osx, linux, windows * need to update ci scripts * have put some core requirements in requirements-dev for now
As users will
TODO Does anything actually use this
|
@englehardt are there tests that are a little flaky? I just have one failing test and i'm a little surprised. i can't kick off a rerun, so if it is a flaky would you mind kicking it? |
| @@ -421,41 +437,11 @@ Once installed, execute `py.test -vv` in the test directory to run all tests. | |||
|
|
|||
| ### Mac OSX (Limited support for developers) | |||
|
|
|||
| We've added an installation file to make it easier to run tests and develop on | |||
There was a problem hiding this comment.
This part of the readme (including the linked wiki page) needs to be updated to reflect the Conda-based installation.
| @@ -68,15 +68,16 @@ def get_geckodriver_exec_path(): | |||
| If the geckodriver executable does not exist next to the Firefox binary, | |||
| we throw a RuntimeError. | |||
| """ | |||
| firefox_binary_path = get_firefox_binary_path() | |||
There was a problem hiding this comment.
Is commenting this out a temporary change?
| sites = ['http://www.example.com', | ||
| 'http://www.princeton.edu', | ||
| 'http://citp.princeton.edu/'] | ||
| NUM_BROWSERS = 1 |
There was a problem hiding this comment.
This PR should probably not change the default number of browsers
| @@ -29,8 +31,8 @@ | |||
| browser_params[0]['headless'] = True # Launch only browser 0 headless | |||
|
|
|||
| # Update TaskManager configuration (use this for crawl-wide settings) | |||
| manager_params['data_directory'] = '~/Desktop/' | |||
| manager_params['log_directory'] = '~/Desktop/' | |||
| manager_params['data_directory'] = 'demo-data' | |||
There was a problem hiding this comment.
This PR should probably not change the default paths
| - tblib | ||
| - pip: | ||
| - publicsuffix | ||
| - plyvel |
There was a problem hiding this comment.
Lovely if Conda makes the Mac-plyvel-installation issues go away! :)
|
|
||
| conda activate openwpm | ||
|
|
||
| Get a copy of firefox and place it in the directory firefox-bin |
There was a problem hiding this comment.
The Mac install script does not place it in firefox-bin, we can opportunistically update the docs to reflect that here now :)
| instrumentation extension or run tests you will also need to install the | ||
| development dependencies included in `install-dev.sh`. | ||
|
|
||
| It is likely that OpenWPM will work on platforms other than Ubuntu, however |
There was a problem hiding this comment.
This comment should remain since this PR does not add full support for Mac and Windows.
| @@ -16,18 +16,31 @@ version of Firefox. | |||
| Installation | |||
| ------------ | |||
|
|
|||
| OpenWPM has been developed and tested on Ubuntu 14.04/16.04. An installation | |||
There was a problem hiding this comment.
The first sentence here should remain, since we do not add tests for Mac and Windows.
| @@ -46,68 +82,6 @@ jobs: | |||
| install: | |||
| script: | |||
| - docker build -f Dockerfile -t openwpm . | |||
| - ./.deploy-to-dockerhub.sh | |||
| - language: node_js | |||
There was a problem hiding this comment.
Please restore the tests for webext-instrumentation. If you find a cleaner way, it'd be great, otherwise just restore as they were. Thanks :)
motin
changed the title
Task: make dependencies conda installable
Why: so we can get going on windows
Side benefit: installation for all platforms will be simplified and unified
Depends on #426