Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin versions for all pip-installed dependencies #499

Closed
englehardt opened this issue Oct 8, 2019 · 0 comments · Fixed by #502
Closed

Pin versions for all pip-installed dependencies #499

englehardt opened this issue Oct 8, 2019 · 0 comments · Fixed by #502

Comments

@englehardt
Copy link
Collaborator

We've had several issues randomly pop up due to changes in our underlying dependencies. These include #439 and #498. We should really pin all of the pip-installed requirements to specific versions. One approach would be to switch over to using pipenv as described in #205.

This post gives a good comparison between our options (at least as of ~1 year ago). The pip-tools suggestion at the end of the post looks reasonable. As stated there, the downside is the lack of support for conditional dependencies. This seems acceptable as we've already decided to drop support for python 2 (see #485).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant