Changes enhance the code's robustness, usability, and maintainability while ensuring it can handle more complex data structures effectively. #297 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unnati-Gupta24
changed the title
nemesifier
changed the title
|
@nemesifier please review this pr and the changes i have enhanced code robustness to handle heavy data effectively |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #297.
Please open a new issue if there isn't an existing issue yet.
Description of Changes
Error Handling:
Replaced console.error with throw new Error(...) for better error management.
Input Validation:
Added a validateNodes method to ensure input data is valid before processing.
Performance Optimization:
Used a Set in arrayDeduplication for tracking duplicates instead of an array.
Support for Nested Properties:
Enhanced arrayDeduplication to handle nested properties using dot notation via getValueByPath.
Custom Key Generation:
Allowed users to provide a custom key generation function in arrayDeduplication.
Documentation Improvements:
Updated JSDoc comments for clarity and added examples where appropriate.
Screenshot
Please include any relevant screenshots.
Screenshot
Please include any relevant screenshots.