Fix a warning that occurs for proctor authentication. #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stopgap measure since this is already fixed in openwebwork#2334, but this was missed in openwebwork#2333. openwebwork#2334 completely rewrites this module.
|
I'll merge this so it won't somehow get in the way of someone testing before and after with #2334. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stopgap measure since this is already fixed in #2334, but this was missed in #2333. #2334 completely rewrites this module.
The
WeBWorK::Authen::create_sessionmethod no longer accepts a prior database key object for its second argument, so the optional third argument (which is now the optional second argument) is in the wrong place for theWeBWorK::Authen::Proctormodules override of this method.