Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem reported by Alex at 4973307a4e7c50b6e4f1afdc6f2c44433f7e6f8f#commitcomment-23035223 #311

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 11, 2017

Fix problem reported by Alex at 4973307#commitcomment-23035223. The issue is due to trying to set $topList when $top is not a block-level element.

Here is a reduced test case:

BEGIN_PGML
* Item
    continued
END_PGML

Without the patch, this should produce an error message (about not being able to use topItem on PGML::Text). With the patch, it should produce the usual output (a list item with "item continued" as the text).

Once this is pulled to PG-2.13, I will make a PR to develop to make sure the change is reflected there as well.

@mgage
Copy link
Member

mgage commented Jul 12, 2017

Patch works as described.

@mgage mgage merged commit aa85778 into openwebwork:PG-2.13 Jul 12, 2017
@dpvc dpvc deleted the PGML-fix branch July 20, 2017 19:51
@mgage
Copy link
Member

mgage commented Sep 5, 2017

Davide, Has this fix been submitted to develop as well? or does this still need that update?

@dpvc
Copy link
Member Author

dpvc commented Sep 5, 2017

It looks like it was merged into develop when you merged PG-2.13a into develop. I've checked that the two lines are correct in the develop branch. So that should do it.

@mgage
Copy link
Member

mgage commented Sep 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants