You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that the attributes aren't stored anymore in the credential record until after a credential offer has been accepted, there's no easy way to get the credential preview attributes.
E.g. for v1 it looks like this, for v2 it needs a bit different code:
I think we should do something like we did in #877 (probably extend the method added in that PR) where we can retrieve the (indy) attributes for a credential exchange. This is only useful for indy credentials, so I'm thinkgin whether we should extend the top level properties:
Or that we should just add it to the indy data (althoug it won't be strictly the format data then anymore, which it currently is). Both makes sense to me, Only indy uses the attributes, so adding it indy (like we do with the other method (e.g. offerCredential attributes are nested under credentialFormats.indy):
Now that the attributes aren't stored anymore in the credential record until after a credential offer has been accepted, there's no easy way to get the credential preview attributes.
E.g. for v1 it looks like this, for v2 it needs a bit different code:
I think we should do something like we did in #877 (probably extend the method added in that PR) where we can retrieve the (indy) attributes for a credential exchange. This is only useful for indy credentials, so I'm thinkgin whether we should extend the top level properties:
Or that we should just add it to the indy data (althoug it won't be strictly the format data then anymore, which it currently is). Both makes sense to me, Only indy uses the attributes, so adding it indy (like we do with the other method (e.g. offerCredential attributes are nested under
credentialFormats.indy
):I think I'm leaning towards the first approach, but not sure yet.
@jakubkoci, @JamesKEbert, @blu3beri @karimStekelenburg your input is welcome
The text was updated successfully, but these errors were encountered: