Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate received credential against offer #190

Closed
TimoGlastra opened this issue Feb 26, 2021 · 0 comments · Fixed by #254
Closed

Validate received credential against offer #190

TimoGlastra opened this issue Feb 26, 2021 · 0 comments · Fixed by #254
Labels
Type: Bug

Comments

@TimoGlastra
Copy link
Contributor

When receiving a credential we should check whether the data inside the credential matches the data inside the credential offer.

Not doing this means we can accept an offer, while the credential being issued contains different attributes from the credential preview in the credential offer.

Related to #187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add credential info to access attributes TimoGlastra/aries-framework-javascript
1 participant
@TimoGlastra