fix: store recipient keys by default #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
genaris
reviewed
Apr 29, 2024
| @@ -75,6 +80,11 @@ export class DidRecord extends BaseRecord<DefaultDidTags, CustomDidTags, DidReco | |||
| legacyUnqualifiedDid: legacyDid?.unqualifiedDid, | |||
| did: this.did, | |||
| methodSpecificIdentifier: did.id, | |||
|
|
|||
| // Calucate if we have a did document, otherwise use the already present recipient keys | |||
There was a problem hiding this comment.
Suggested change
| // Calucate if we have a did document, otherwise use the already present recipient keys | |
| // Calculate if we have a did document, otherwise use the already present recipient keys |
Signed-off-by: Timo Glastra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating the new
invitationDidwith adid:cheqdDID, I noticed that DIDComm wouldn't work because the recipientKeyFingerprints weren't added.To make it easier, it is now calculated in the did record if the did document is provided, and I've also updated the
did:indyregistrar to store the did document. It's very expensive to resolve these documents, and this will allow us in a future update to shortcut did docs created by us to first look for the local record.But for now, it makes it easy to use any kind of did with DIDComm.