Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oid4vp can be used separate from idtoken #1827

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Apr 10, 2024

The current implementation always requires ID Token to be used with VP Token. That is not required, and was a misunderstanding on my side.

This PR addresses it but it needs Sphereon-Opensource/SIOP-OID4VP#76 in SIOP-OID4VP to be merged and released first

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
Copy link
Contributor Author

TimoGlastra commented Apr 13, 2024

I've temporarily applied a fork of SIOP-OID4VP as dependency. We should wait with merging until the changes are released so keeping in draft until then

https://github.com/animo/SIOP-OID4VP/tree/release

@TimoGlastra TimoGlastra marked this pull request as ready for review April 24, 2024 22:34
@TimoGlastra TimoGlastra merged commit ca383c2 into openwallet-foundation:main Apr 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants