fix: node-ffi-napi-compatibility #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
berendsliedrecht
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to re-gain compatibliity with latest node versions (18.20, 20.12, 21.6) by using a patched version of
@2060.io/ffi-napi. The issue was caused by an experimental feature in N-API (see this commit), which was enabled when compiling ffi-napi because it hadNAPI_EXPERIMENTALflag set (originally this was needed until the release of node 12.17, but the flag wasn't removed since the repo was not being maintained after that).Given that
@hyperledger/aries-askar-nodejs,@hyperledger/indy-vdr-nodejsand@hyperledger/anoncredshad pinned previous version of ffi-napi, I think we'll need to do a new minor release of those modules before merging this, since at the moment we need to pin this new version inresolutions.