feat: updated getAllPoolTransactions method #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <[email protected]>
wadeking98
force-pushed
the
feat-updated-fetch-pool-txns
branch
from
41b8b8e to
e58100d
Compare
genaris
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Thanks @wadeking98 ! Note that this introduces a small breaking change, since this method return is being returned directly by an IndyVdrApi public method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
getAllPoolTransactionsmethod to include the pool config as part of the result so we know which pool is which.BC Wallet already uses this in a yarn patch to the Credo-ts package. I figured I'd get it in the main repo so others could use it and we didn't have to keep maintaining the patch.