feat: add support for key type k256 #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
…o-ts into feat/add-key-k256
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
|
Do the tests run locally for you @sairanjit? It keeps failing, and I'm not sure if it's related to your changes or not |
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
auto-merge was automatically disabled
January 31, 2024 15:19
Head branch was pushed to by a user without write access
|
Ah I merged #1629 and now there's some merge conflicts. Can you address it? |
I will check the tests and also run locally again |
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
TimoGlastra
reviewed
Jan 31, 2024
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
k256did:keyfor the curve -secp256k1