feat: update dockerfile to node 18 and sample mediator to askar #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <[email protected]>
berendsliedrecht
approved these changes
Oct 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #1622 +/- ##
=======================================
Coverage 85.66% 85.66%
=======================================
Files 950 950
Lines 22879 22879
Branches 4022 4022
=======================================
Hits 19600 19600
Misses 3095 3095
Partials 184 184 |
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Nov 15, 2023
…wallet-foundation#1622) Signed-off-by: Ariel Gentile <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Dec 4, 2023
…wallet-foundation#1622) Signed-off-by: Ariel Gentile <[email protected]> Signed-off-by: Martin Auer <[email protected]>
genaris
added a commit
to genaris/credo-ts
that referenced
this pull request
Dec 4, 2023
…wallet-foundation#1622) Signed-off-by: Ariel Gentile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate solution until we finally remove
indy-sdkdependency: current Dockerfile won't work because it install node 16 and we now require at least 18, so here we are updating it. Also upgraded sample mediator to use Aries Askar, which now works properly due to the patchedref-napilibrary.Resolves #1621