Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abandon proof protocol if presentation fails #1610

Conversation

TimoGlastra
Copy link
Contributor

Abandon the proof protocol if the presentation processing fails. It will send a problem report, and it will set the error message on the proof record.

@TimoGlastra TimoGlastra requested a review from a team as a code owner October 19, 2023 09:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #1610 (7ff1d5a) into main (5cac2be) will decrease coverage by 3.63%.
The diff coverage is 35.89%.

@@            Coverage Diff             @@
##             main    #1610      +/-   ##
==========================================
- Coverage   85.75%   82.13%   -3.63%     
==========================================
  Files         951      951              
  Lines       22863    22892      +29     
  Branches     4018     4024       +6     
==========================================
- Hits        19606    18802     -804     
- Misses       3073     3825     +752     
- Partials      184      265      +81     
Files Coverage Δ
...dules/proofs/protocol/v2/ProofFormatCoordinator.ts 96.00% <66.66%> (-2.32%) ⬇️
.../src/modules/proofs/protocol/v2/V2ProofProtocol.ts 91.88% <38.46%> (-1.87%) ⬇️
...oncreds/src/protocols/proofs/v1/V1ProofProtocol.ts 85.75% <17.64%> (-3.04%) ⬇️

... and 32 files with indirect coverage changes

@TimoGlastra TimoGlastra enabled auto-merge (squash) October 19, 2023 12:54
@TimoGlastra TimoGlastra merged commit b2ba7c7 into openwallet-foundation:main Oct 19, 2023
7 checks passed
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Nov 15, 2023
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Dec 4, 2023
genaris pushed a commit to genaris/credo-ts that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants