New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught error when processing message with unknown content type #1310

Closed

andrewwhitehead opened this issue Feb 17, 2023 · 0 comments · Fixed by #1313

Milestone

andrewwhitehead commented Feb 17, 2023

I discovered that when a DIDComm message is sent without the DIDComm (V0 or V1) content type, AFJ receives a payload which cannot be parsed as JSON. This leads to an error here: https://github.com/hyperledger/aries-framework-javascript/blob/03cdf397b61253d2eb20694049baf74843b7ed92/packages/node/src/transport/HttpInboundTransport.ts#L45

The result is that the sender receives a 500 error, instead of something like 400 Bad Request or 415 Unsupported Media Type.

TimoGlastra mentioned this issue

fix: return http 415 if unsuporrted content type #1313

Merged

TimoGlastra added this to the 0.4.0 milestone

genaris closed this as completed in #1313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment