Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create IndyVdrAnonCredsRegistry without revocation #1239

Closed
TimoGlastra opened this issue Jan 24, 2023 · 1 comment · Fixed by #1270
Closed

Create IndyVdrAnonCredsRegistry without revocation #1239

TimoGlastra opened this issue Jan 24, 2023 · 1 comment · Fixed by #1270
Assignees

Comments

@TimoGlastra
Copy link
Contributor

TimoGlastra commented Jan 24, 2023

Create an IndyVdrAnonCredsRegistry that implements the AnonCredsRegistry interface from the @aries-framework/anoncreds package using the indy vdr library.

  • Implement the AnonCredsRegistry interface methods from the anoncreds package.
    • read/write schema
    • read/write credential definition
    • return not implemented error for revocation status list and revocation registry definition
    • add tests
    • should be added to the @aries-framework/indy-vdr package
  • Utils present in the indy-sdk package that are needed, can be copied to the indy-vdr package.
  • The overall structure can stay the same (responses etc..), but we should update it to use the IndyVdrPoolService
  • The indyVdrPoolService can be injected using agentContext.dependencyManager.resolve(IndyVdrPoolService)

Resources

Can use the IndySdkAnonCredsRegistry as an example, but must be updated to use the IndyVdrPoolService and IndyVdrPool.

We may need to transform the structure of some objects. As the AnonCreds interfaces are different than what is stored on the indy ledger. However, the same transformations are present in the IndySdkAnonCredsRegistry class, so should make sure it is correct, but we can mostly copy the transformations from the existing implementaiton.

@TimoGlastra TimoGlastra converted this from a draft issue Jan 24, 2023
@Vickysomtee
Copy link
Contributor

Working on this!

@TimoGlastra TimoGlastra moved this from Todo to In Progress in Ledger Agnostic AnonCreds Feb 6, 2023
@genaris genaris linked a pull request Feb 15, 2023 that will close this issue
@genaris genaris closed this as completed Feb 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ledger Agnostic AnonCreds Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants