Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof request specifying a non-revocation interval fails when providing non-revocable credentials #698

Closed
esune opened this issue Aug 27, 2020 · 1 comment

Comments

@esune
Copy link
Member

esune commented Aug 27, 2020

When a verifier submits a proof request that contains a non-revocation interval and the holder responds using non-revocable credentials that meet the remaining restrictions, the verification of the proof fails and the verifier throws the following exception:

Faber      | 2020-08-26 17:23:52,896 aries_cloudagent.verifier.indy ERROR Validation of presentation on nonce=561590513150476300113269 failed with error
Faber      | Traceback (most recent call last):
Faber      | Proof = false
Faber      | Presentation: state = verified , presentation_exchange_id = 1b704966-bbba-4def-8cb9-26b3ea956ec8
Faber      |   File "/home/indy/aries_cloudagent/verifier/indy.py", line 211, in verify_presentation
Faber      |     json.dumps(rev_reg_entries),
Faber      |   File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/indy/anoncreds.py", line 1756, in verifier_verify_proof
Faber      |     verifier_verify_proof.cb)
Faber      | indy.error.CommonInvalidStructure

This seems to be caused by "missing" revocation information when verifying the proof.

The situation described above is the default use-case for authentication scenarios (e.g.: vc-authn-oidc) where the Identity Provider will ALWAYS send a non-revocation interval in the proof request regardless of the type of credentials (revocable or not) that can be accepted, since it cannot be known ahead of time.

@sklump

@sklump
Copy link
Contributor

sklump commented Aug 27, 2020

#699 addresses.

@sklump sklump closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants