Inconsistent behaviour on duplicate POST /schema and POST /credential-definitions

[jcourt562]

Version: 0.5.3

Expected Result: Either POST /schema should return 422 on duplicates OR POST /credential-definitions should return 200 on duplicates.

Description : When creating a duplicate schema with the same schema_version and schema_name and DID it returns a 200 result, presumably treating this as success because the resource already exists and no action is taken. However when creating a duplicate credential definition with the same schema_id and tag and DID a 422 error is returned. Duplicates of both types should be handled consistently.

[sklump]

I will look into this, but they may not come out to be the same thing. Credential definitions require private keys; schemas do not. Getting 422 seems wrong though.

[sklump]

I can't reproduce the 422. I have streamlined the non-secret record creation logic to parallel that of send-schema: #683.

If you still encounter this, I need details of what you're sending.

[jcourt562]

I will run again with updated code and get you the request response output for duplicate credentials if the issue still exists.
Thanks

[sklump]

To be clear: I need the request JSON for every request to get you to this point, and the corresponding responses, in order. Please and thanks.

[jcourt562]

I ran through this again today with the latest from master and couldn't reproduce. Closing this as either I had some strange environment situation or the problem was resolved by the code re-org mentioned above.

Thanks.