Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /schemas/{schema_id} models say a "schema_json" object is returned when actually "schema" is returned #675

Closed
jcourt562 opened this issue Aug 21, 2020 · 1 comment

Comments

@jcourt562
Copy link
Contributor

The swagger api and code generated via codegen provides an interface expecting a "schema_json" object returned from "GET /schemas/{schema_id}". In fact the body in the response returns a "schema" object. This makes it difficult in many languages to access the data returned. Suggest that the swagger I/f change to "schema" since that is what working client code must be using to access the data. The response body coming back from a running ACA-py v0.5.3 is :

{"schema": {"ver": "1.0", "id": "FfTM7q3uZLipmQnXjghcbZ:2:University_Transcript:0.1", "name": "University_Transcript", "version": "0.1", "attrNames": ["first_name", "last_name"], "seqNo": 8}}

I have submitted a one line pull request to fix this.

@sklump
Copy link
Contributor

sklump commented Aug 21, 2020

#674 addresses.

@sklump sklump closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants