Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare and release ACA-Py 0.4.1 #342

Closed
swcurran opened this issue Jan 23, 2020 · 1 comment
Closed

Prepare and release ACA-Py 0.4.1 #342

swcurran opened this issue Jan 23, 2020 · 1 comment
Assignees

Comments

@swcurran
Copy link
Contributor

Please include work up until now, plus:

As well, we need the issues raised in Aries RFCs 391 resolved and included. Needed for ACA-Py are updates to the presentation verification (checking raw vs. encoded) and possibly the encoding algorithm which is being questioned.

Please monitor if anything else is needed, but the sooner the better and NLT Wednesday with at least the three required PRs.

@sklump
Copy link
Contributor

sklump commented Jan 24, 2020

The encoding algorithm has been present from day 1:

https://github.com/hyperledger/aries-cloudagent-python/blob/401a82b10a33accd391b465f902dddc98da81803/aries_cloudagent/issuer/util.py#L9

Any change to it will make every aca-py and every indy-cat-agent credential in history ineligible for use in proofs once the raw/encoding check is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants