Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noisy logs #3202

Open
rngadam opened this issue Aug 28, 2024 · 9 comments · May be fixed by #3332
Open

Noisy logs #3202

rngadam opened this issue Aug 28, 2024 · 9 comments · May be fixed by #3332

Comments

@rngadam
Copy link
Contributor

rngadam commented Aug 28, 2024 •
edited
Loading

At the agent start, the stdout of the agent shows multiple banner messages and output from print statements.

Having noisy logs makes it more difficult to identify quickly actual problems.

Expect to:

  • be able to suppress those banner messages
  • not have print statements (should be logging)

list of print statements

https://gist.github.com/rngadam/3cccd0f515091544f745d681d8119ae4
@rngadam rngadam mentioned this issue Aug 28, 2024
Closed
rngadam added a commit to rngadam/aries-cloudagent-python that referenced this issue Aug 28, 2024
@rngadam
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
606432f 
…nt by logging statements
rngadam added a commit to rngadam/aries-cloudagent-python that referenced this issue Aug 28, 2024
@rngadam
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
3f90fa6 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
@rngadam rngadam mentioned this issue Aug 28, 2024
Closed
rngadam added a commit to rngadam/aries-cloudagent-python that referenced this issue Aug 28, 2024
@rngadam
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
2dd65ce 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
rngadam added a commit to rngadam/aries-cloudagent-python that referenced this issue Aug 28, 2024
@rngadam
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
8b1e818 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
@WadeBarnes
Copy link
Contributor

WadeBarnes commented Aug 28, 2024 •
edited
Loading

The deprecation banner and notices should only be displayed when you are using deprecated features. Suppressing these messages defeats the purpose of the messages - to let you know you are using deprecated features and you should migrate to alternate (replacement) features. So, the best practice way to get rid of the messages is to migrate away from the deprecated features you're using.

I do agree the messages should be logged rather than being printed.

Regarding the standard ACA-Py startup banner. I think this is a very important piece of diagnostic information that should not be suppressed. It provides you with a summary of the agent configuration and version that can help you identify issues right off the bat.

@rngadam
Copy link
Contributor Author

rngadam commented Aug 28, 2024

The deprecation banner and notices should only be displayed when you are using deprecated features. Suppressing these messages defeats the purpose of the messages - to let you know you are using deprecated features and you should migrate to alternate (replacement) features. So, the best practice way to get rid of the messages is to migrate away from the deprecated features you're using.

I expected that too, but if you look at the code the banner is printed everytime (there's no conditional):

from here:

https://github.com/hyperledger/aries-cloudagent-python/blob/90895bbc3f2bf203bbfe35f0464a9ea1f37ebeaa/aries_cloudagent/core/conductor.py#L321-L338

the only condition for printing the deprecation notice is having transports configured (aka transport is not disabled)

https://github.com/hyperledger/aries-cloudagent-python/blob/90895bbc3f2bf203bbfe35f0464a9ea1f37ebeaa/aries_cloudagent/config/logging.py#L389-L429

It's giving a deprecation notice whatever config and even though #2368 is not done yet. Correct me if I'm wrong, but there seems to be no way to "correctly" configure the agent to get rid of the deprecation notice.

@rngadam
Copy link
Contributor Author

rngadam commented Aug 28, 2024

Regarding the standard ACA-Py startup banner. I think this is a very important piece of diagnostic information that should not be suppressed. It provides you with a summary of the agent configuration and version that can help you identify issues right off the bat.

Perhaps in regular usage but it interferes with testing (I'm forking 100 agents from the same parent process, creating a storm of output) and creates the habit of eventually ignoring output that could/should be important.

@WadeBarnes
Copy link
Contributor

It's giving a deprecation notice whatever config and even though #2368 is not done yet. Correct me if I'm wrong, but there seems to be no way to "correctly" configure the agent to get rid of the deprecation notice.

@swcurran, @dbluhm, @jamshale, Can any of you comment on this?

rngadam added a commit to rngadam/aries-cloudagent-python that referenced this issue Aug 28, 2024
@rngadam
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
12da754 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
@jamshale
Copy link
Contributor

I don't think we'd want to add another configuration for this. We're really trying not to bloat the configurations. But, printing the banner nicely with the logger will be a bit tricky because it's configured to print the timestamp and class.

This seems like a pretty niche use case. The depreciation notice is only like 10 lines of output. If other maintainers don't care about adding a configuration than the open PR looks acceptable.

@swcurran
Copy link
Contributor

I don’t like the idea of the flag to block the banner. The whole point of the messages is that they be ugly and in the face of the deployers so that they become aware of the need to evolve their deployment. Especially if they go away when the deployment removes the deprecated feature. That’s the behaviour we want to encourage — “This message will not be printed if you update your deployment to do X, Y and Z. Do it today!!”.

If a deployment simply adds that flag, they will not see the future messages and will not know about future deprecations.

I think we should not add this.

@rngadam
Copy link
Contributor Author

rngadam commented Aug 28, 2024

@swcurran @jamshale as it is now, there's no way around the "deprecation notice".

It is deprecating something without any working alternatives to upgrade to.

For me, that is not deprecation, it is noise for which I cannot do anything about, polluting my stdout and causing me to miss actual important error messages.

@jamshale
Copy link
Contributor

Why don't you just test with your own fork or image? Or you should be able to filter your log output for single instances. You could also spread your instances startups out do the logs aren't all mixed up.

There is a lot of ways around this and finding these errors easier isn't something we need to fix by adding another configuration parameter.

@swcurran
Copy link
Contributor

What deprecation are you talking about? Do you mean this one?

:: Receiving a core DIDComm protocol with the `did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` ::
:: prefix is deprecated. All parties sending this prefix should be notified that    ::
:: support for receiving such messages will be removed in a future release. Use     ::
:: https://didcomm.org/ instead.

If so, that is not about “did:sov” vs. “did:indy”. Rather — it is the prefix to a DIDComm message type, such as:
https://didcomm.org/basicmessage/1.0/ which used to be sent as did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/basicmessage/1.0/. The did:sov… part of that is a specific DID and is treated as a hard-coded string in the initial DIDComm protocols. We’re trying to eliminate it from the code base.

I fully agree that there should be a way to suppress such messages, and I’m not sure about this one, since the message is saying “hey, if you get a message from another party using the old prefix you should yell at them”. There is a flag to ensure that your deployment is not sending out such a prefix (since 0.5.5), and that flag is now automatically active for all ACA-Py deployments (since 0.11.0).

How about we do this:

  1. Remove the did:sov DIDComm message type prefix deprecation message as it has been two full releases since ACA-Py was changed to only send out the https://didcomm.org replacement.
  2. Document that all deprecation messages SHOULD provide information (or a link) to how the message can be suppressed — usually by migrating to the replacement approach. That cannot be a universal “Don’t show deprecation messages”, since that defeats their very valuable purpose.
  3. Nice to have — update the existing messages according to 2.

Thoughts?

ff137 pushed a commit to didx-xyz/acapy that referenced this issue Nov 5, 2024
@rngadam @ff137
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
6d70441 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
ff137 pushed a commit to didx-xyz/acapy that referenced this issue Nov 6, 2024
@rngadam @ff137
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
97045ad 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
@ff137 ff137 linked a pull request Nov 7, 2024 that will close this issue
Draft
ff137 pushed a commit to didx-xyz/acapy that referenced this issue Nov 7, 2024
@rngadam @ff137
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
e99e151 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
ff137 pushed a commit to didx-xyz/acapy that referenced this issue Nov 12, 2024
@rngadam @ff137
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
194c033 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
ff137 pushed a commit to didx-xyz/acapy that referenced this issue Nov 13, 2024
@rngadam @ff137
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
e6a1c00 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
ff137 pushed a commit to didx-xyz/acapy that referenced this issue Nov 14, 2024
@rngadam @ff137
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
53d00fd 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
ff137 pushed a commit to didx-xyz/acapy that referenced this issue Dec 2, 2024
@rngadam @ff137
Fixes openwallet-foundation#3202: new suppress banner and replace pri…
3e1029f 
…nt by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>
ff137 added a commit to didx-xyz/acapy that referenced this issue Dec 5, 2024
@ff137 @dbluhm
@dependabot @jamshale @swcurran @esune @rngadam @ianco
♻️ Sync development with main and ✨ improve logging (#8)
b72569e 
* ⬆️ Upgrade python-dateutil

Resolves calling deprecated `datetime.utcfromtimestamp` method

Signed-off-by: ff137 <[email protected]>

* 🎨 Rename class to resolve PytestCollectionWarning

Signed-off-by: ff137 <[email protected]>

* 🎨 Replace deprecated `open_binary` method with `files`

Signed-off-by: ff137 <[email protected]>

* 🎨 Replace deprecated `scope` keyword with `loop_scope`

Signed-off-by: ff137 <[email protected]>

* 🎨 Filter Aries RFC 0160 DeprecationWarning in tests

Signed-off-by: ff137 <[email protected]>

* 🎨 Filter Pydantic UserWarning in test

Signed-off-by: ff137 <[email protected]>

* ⬆️ Upgrade aiohttp to latest release and update lock file

Signed-off-by: ff137 <[email protected]>

* 🎨 Remove unnecessary asyncio pytest markers

Resolves unclosed event loop warnings.

Signed-off-by: ff137 <[email protected]>

* chore(deps-dev): Bump ruff from 0.7.3 to 0.7.4 (openwallet-foundation#3341)

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.3 to 0.7.4.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.7.3...0.7.4)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump aiohttp from 3.11.0 to 3.11.2 (openwallet-foundation#3340)

Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.11.0 to 3.11.2.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.11.0...v3.11.2)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump pyjwt from 2.9.0 to 2.10.0 (openwallet-foundation#3339)

Bumps [pyjwt](https://github.com/jpadilla/pyjwt) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/jpadilla/pyjwt/releases)
- [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst)
- [Commits](jpadilla/pyjwt@2.9.0...2.10.0)

---
updated-dependencies:
- dependency-name: pyjwt
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* did:tdw resolver (openwallet-foundation#3237)

* did:tdw resolver

Signed-off-by: jamshale <[email protected]>

* Update unit tests

Signed-off-by: jamshale <[email protected]>

* Update poetry.lock

Signed-off-by: jamshale <[email protected]>

---------

Signed-off-by: jamshale <[email protected]>

* chore(deps): Bump aiohttp (openwallet-foundation#3342)

Bumps the pip group with 1 update in the /scenarios directory: [aiohttp](https://github.com/aio-libs/aiohttp).


Updates `aiohttp` from 3.10.5 to 3.10.11
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.10.5...v3.10.11)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: indirect
  dependency-group: pip
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jamshale <[email protected]>

* 🎨 Refactor `register_plugin` steps for maintainability

Signed-off-by: ff137 <[email protected]>

* 🎨 improve logging in register_package

Signed-off-by: ff137 <[email protected]>

* 🎨 Rename method and remove redundant main call

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

* 🔊 Add debug logging to Context Builder

Signed-off-by: ff137 <[email protected]>

* 🎨 Deduplicate registering list of plugins

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

* 🔊 Add debug logging to init_context

Signed-off-by: ff137 <[email protected]>

* 🔊 Add debug logging to load_protocol_version

Signed-off-by: ff137 <[email protected]>

* 🔊 Add debug logging to load_protocols

Signed-off-by: ff137 <[email protected]>

* 🔊 Add debug logging to register_admin_routes

Signed-off-by: ff137 <[email protected]>

* 🔊 Add debug logging to register_protocol_events

Signed-off-by: ff137 <[email protected]>

* 🔊 Add debug logging to post_process_routes

Signed-off-by: ff137 <[email protected]>

* 🎨 Replace print statements with info logs

Signed-off-by: ff137 <[email protected]>

* 🎨 Replace almost all print statements with info logs

Signed-off-by: ff137 <[email protected]>

* 🔊 Expand logging for Conductor setup

Signed-off-by: ff137 <[email protected]>

* 🎨 Correct to uphold previous "Module doesn't exist" log behaviour

Signed-off-by: ff137 <[email protected]>

* ✅ Fix test by using assertLogs instead of capturing stdout

Signed-off-by: ff137 <[email protected]>

* Revert "🎨 Rename method and remove redundant main call"

This reverts commit 2f6526d.

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

* ✅ Fix test by adding __name__ to mock object

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

* ✨ Add custom trace log level

Signed-off-by: ff137 <[email protected]>

* 🎨 Ensure trace level can only be added once

Signed-off-by: ff137 <[email protected]>

* 🎨 Add Logger

Signed-off-by: ff137 <[email protected]>

* 🎨 Update newly added logs to be trace level instead of debug

Signed-off-by: ff137 <[email protected]>

* 🎨 Update newly added logs to be trace level instead of debug

Signed-off-by: ff137 <[email protected]>

* 🔊 Expand logging for Conductor start and stop

Signed-off-by: ff137 <[email protected]>

* ✅ Add unit tests for adding trace level functionality

Signed-off-by: ff137 <[email protected]>

* ✅ Reset the logging states before and after TestLoggingUtils is run

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

* 🧪 Debug log assertion test failing sporadically

Filter the logs being read by module name, and add short sleep to allow log handlers to flush

Signed-off-by: ff137 <[email protected]>

* ✅ Modify log assertion to be more robust

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

* 🐛 Handle case that load_module return type is Optional

Signed-off-by: ff137 <[email protected]>

* 🔊 Expand logging for ClassLoader

Signed-off-by: ff137 <[email protected]>

* 🔊 Log a warning if resource not found, instead of passing

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

* 🎨 Enable trace logs for remaining modules

Signed-off-by: ff137 <[email protected]>

* 🐛 Fix registering and loading of modules

Signed-off-by: ff137 <[email protected]>

* 🔊 Expand logging for Ledger Configuration

Signed-off-by: ff137 <[email protected]>

* Fix tails upload for anoncreds multitenancy

Signed-off-by: jamshale <[email protected]>

* Update unit test

Signed-off-by: jamshale <[email protected]>

* Make sonarcloud happy with https in test

Signed-off-by: jamshale <[email protected]>

* Add anoncreds issuance and presentation format (openwallet-foundation#3331)

* Add anoncreds issuance and presentation formats

Signed-off-by: jamshale <[email protected]>

* Fix unit tests

Signed-off-by: jamshale <[email protected]>

* Fix error in _formats_attach

Signed-off-by: jamshale <[email protected]>

* Fix AnoncredsDID validation pattern

Signed-off-by: jamshale <[email protected]>

* Fix name

Signed-off-by: jamshale <[email protected]>

* Fix scenario test

Signed-off-by: jamshale <[email protected]>

* Update demo with anoncreds format

Signed-off-by: jamshale <[email protected]>

* Fix the scenario test and add better description

Signed-off-by: jamshale <[email protected]>

* Add service_healthy check for indy agent

Signed-off-by: jamshale <[email protected]>

* Fix/update BDD tests

Signed-off-by: jamshale <[email protected]>

* Add issuer askar to holder anoncreds support

Signed-off-by: jamshale <[email protected]>

* Update BDD tests

Signed-off-by: jamshale <[email protected]>

* Remove commented code

Signed-off-by: jamshale <[email protected]>

* Expand scenario test

Signed-off-by: jamshale <[email protected]>

* Add better comments for format compatibilty imports

Signed-off-by: jamshale <[email protected]>

* Add anocnreds compatibilty bdd test to PR workflow

Signed-off-by: jamshale <[email protected]>

---------

Signed-off-by: jamshale <[email protected]>

* Fix handling of base_wallet_routes startup parameter in auth decorator

Signed-off-by: Emiliano Suñé <[email protected]>

* Restore --base-wallet-extra-routes argument functionality

Signed-off-by: Emiliano Suñé <[email protected]>

* Correctly handle null value for --base-wallet-routes

Signed-off-by: Emiliano Suñé <[email protected]>

* Fix typo

Signed-off-by: Emiliano Suñé <[email protected]>

* Fix subwallet anoncreds upgrade check (openwallet-foundation#3345)

Signed-off-by: jamshale <[email protected]>

* Fix/universal resolver (openwallet-foundation#3354)

* Update universal resolver response handling

Signed-off-by: jamshale <[email protected]>

* Update universal resolver unit test

Signed-off-by: jamshale <[email protected]>

* Add reverse compatibility handling

Signed-off-by: jamshale <[email protected]>

---------

Signed-off-by: jamshale <[email protected]>

* chore(deps-dev): Bump ruff from 0.7.4 to 0.8.0 (openwallet-foundation#3348)

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.4 to 0.8.0.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.7.4...0.8.0)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jamshale <[email protected]>

* chore(deps): Bump mkdocs-material from 9.5.44 to 9.5.46 (openwallet-foundation#3352)

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.44 to 9.5.46.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.44...9.5.46)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump uuid-utils from 0.9.0 to 0.10.0 (openwallet-foundation#3351)

Bumps [uuid-utils](https://github.com/aminalaee/uuid-utils) from 0.9.0 to 0.10.0.
- [Release notes](https://github.com/aminalaee/uuid-utils/releases)
- [Commits](aminalaee/uuid-utils@0.9.0...0.10.0)

---
updated-dependencies:
- dependency-name: uuid-utils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): Bump debugpy from 1.8.8 to 1.8.9 (openwallet-foundation#3350)

Bumps [debugpy](https://github.com/microsoft/debugpy) from 1.8.8 to 1.8.9.
- [Release notes](https://github.com/microsoft/debugpy/releases)
- [Commits](microsoft/debugpy@v1.8.8...v1.8.9)

---
updated-dependencies:
- dependency-name: debugpy
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump aiohttp from 3.11.2 to 3.11.7 (openwallet-foundation#3349)

Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.11.2 to 3.11.7.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.11.2...v3.11.7)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ⏪ Revert `trace` log changes, and move to debug level

Signed-off-by: ff137 <[email protected]>

* ✨ Add caching to ClassLoader.load_module

Signed-off-by: ff137 <[email protected]>

* 🎨 Improve log

Signed-off-by: ff137 <[email protected]>

* 🎨 Sync Ruff version in configs and apply formatting (openwallet-foundation#3358)

* ⬆️ Upgrade ruff version in pre-commit config and lint workflow

Signed-off-by: ff137 <[email protected]>

* 🎨 Apply ruff formatting

Signed-off-by: ff137 <[email protected]>

* ⬆️ Upgrade pre-commit hook version

Signed-off-by: ff137 <[email protected]>

---------

Signed-off-by: ff137 <[email protected]>

* 🎨 Replace deprecated ABC decorators (openwallet-foundation#3357)

Signed-off-by: ff137 <[email protected]>
Co-authored-by: jamshale <[email protected]>

* 🎨 Reduce log verbosity

Signed-off-by: ff137 <[email protected]>

* ✨ Add `lru_cache` to load_class and set maxsize

Signed-off-by: ff137 <[email protected]>

* ⚡ Add class caching to DeferLoad

Resolves openwallet-foundation#3360

Signed-off-by: ff137 <[email protected]>

* ⏪ Revert addition of lru caching

Signed-off-by: ff137 <[email protected]>

* 🎨 Update logs / reduce verbosity

Signed-off-by: ff137 <[email protected]>

* Revert "Don't pass rekey to sub_wallet_profile"

This reverts commit e59d275.

* Fixes openwallet-foundation#3202: new suppress banner and replace print by logging statements

Signed-off-by: Ricky Ng-Adam <[email protected]>

* 🎨 Print agent label and version even if banner suppressed

Signed-off-by: ff137 <[email protected]>

* ✅ Fix pagination assertions

Signed-off-by: ff137 <[email protected]>

* 👷 Upload Python Package to TestPyPI (#4)

* 👷 Upload Python Package to TestPyPI

Signed-off-by: ff137 <[email protected]>

* 👷 Update project name and version for testpypi

Signed-off-by: ff137 <[email protected]>

* 🎨

Signed-off-by: ff137 <[email protected]>

---------

Signed-off-by: ff137 <[email protected]>

* Version 1.1.1-20241115

Signed-off-by: ff137 <[email protected]>

* 🎨 Deprecate count/start query params and implement limit/offset (#6)

* art: Modify count/start query params to be Integers, not Strings

Signed-off-by: ff137 <[email protected]>

* memo: Update openapi spec

Signed-off-by: ff137 <[email protected]>

* rewind: Revert start/count field to remain String type; mark as deprecated

Signed-off-by: ff137 <[email protected]>

* sparkles: Implement limit/offset alongside deprecated count/start

Signed-off-by: ff137 <[email protected]>

* art: Standardise naming convention from count/start to limit/offset

Signed-off-by: ff137 <[email protected]>

* rewind: Revert start/count field to remain String type; mark as deprecated

Signed-off-by: ff137 <[email protected]>

* sparkles: Implement limit/offset alongside deprecated count/start

Signed-off-by: ff137 <[email protected]>

* art: Remove unused query string schema from `w3c_creds_list`

Signed-off-by: ff137 <[email protected]>

* art: Rename args

Signed-off-by: ff137 <[email protected]>

* memo: Update openapi specs

Signed-off-by: ff137 <[email protected]>

* white_check_mark:

Signed-off-by: ff137 <[email protected]>

---------

Signed-off-by: ff137 <[email protected]>

* sparkles: add `order_by` and `descending` options to query / scan and fetch_all methods

Signed-off-by: ff137 <[email protected]>

* sparkles: add `order_by` and `descending` options to PaginatedQuerySchema

Signed-off-by: ff137 <[email protected]>

* sparkles: modify `get_limit_offset` to `get_paginated_query_params`

Signed-off-by: ff137 <[email protected]>

* construction: test in-progress aries-askar PR: openwallet-foundation/askar#291

Signed-off-by: ff137 <[email protected]>

* arrow_up: Update lock file

Signed-off-by: ff137 <[email protected]>

* art: fix ruff warning

Signed-off-by: ff137 <[email protected]>

* white_check_mark: fix assertions

Signed-off-by: ff137 <[email protected]>

* construction: test aries-askar with TestPyPI package

Signed-off-by: ff137 <[email protected]>

* construction: test latest askar testpypi package

Signed-off-by: ff137 <[email protected]>

* art: Update order_by description and default value. Include in schema

Signed-off-by: ff137 <[email protected]>

* bug: fix deserialisation of descending: bool parameter

Signed-off-by: ff137 <[email protected]>

* rewind: revert to testing 0.3.3b0 askar test package

Signed-off-by: ff137 <[email protected]>

* fire: remove unnecessary record sorts (now that askar sorts by id == sorting by created_at)

Signed-off-by: ff137 <[email protected]>

* white_check_mark: fix test assertions -- wallet_list and connections_list no longer does additional sorting

Signed-off-by: ff137 <[email protected]>

* arrow_up: Update lock file

Signed-off-by: ff137 <[email protected]>

* art: Modify count/start query params to be Integers, not Strings

Signed-off-by: ff137 <[email protected]>

* memo: Update openapi spec

Signed-off-by: ff137 <[email protected]>

* rewind: Revert start/count field to remain String type; mark as deprecated

Signed-off-by: ff137 <[email protected]>

* sparkles: Implement limit/offset alongside deprecated count/start

Signed-off-by: ff137 <[email protected]>

* art: Standardise naming convention from count/start to limit/offset

Signed-off-by: ff137 <[email protected]>

* rewind: Revert start/count field to remain String type; mark as deprecated

Signed-off-by: ff137 <[email protected]>

* sparkles: Implement limit/offset alongside deprecated count/start

Signed-off-by: ff137 <[email protected]>

* art: Remove unused query string schema from `w3c_creds_list`

Signed-off-by: ff137 <[email protected]>

* art: Rename args

Signed-off-by: ff137 <[email protected]>

* memo: Update openapi specs

Signed-off-by: ff137 <[email protected]>

* white_check_mark:

Signed-off-by: ff137 <[email protected]>

* art: Update start/count keywords to offset/limit

Signed-off-by: ff137 <[email protected]>

* 🐛 Fix IndyVdrLedgerPool RuntimeWarning

Resolves openwallet-foundation#3328

Signed-off-by: ff137 <[email protected]>

* 🧪 Update tests

Signed-off-by: ff137 <[email protected]>

* Revert "did:tdw resolver (openwallet-foundation#3237)"

This reverts commit f5c49b0.

Signed-off-by: ff137 <[email protected]>

* 1.1.1b5

Signed-off-by: ff137 <[email protected]>

* 🎨 Propagate the async changes

Signed-off-by: ff137 <[email protected]>

* 🎨 Propagate the async changes

Signed-off-by: ff137 <[email protected]>

* Add test wallet config option (openwallet-foundation#3355)

* Add test wallet config option

Signed-off-by: jamshale <[email protected]>

* Change wallet test arg to store true / Fix tests

Signed-off-by: jamshale <[email protected]>

* Add unit test with test wallet config

Signed-off-by: jamshale <[email protected]>

---------

Signed-off-by: jamshale <[email protected]>

* Week 49 Library upgrades (openwallet-foundation#3368)

Signed-off-by: jamshale <[email protected]>

* ⚡ Add class caching to DeferLoad (openwallet-foundation#3361)

Resolves openwallet-foundation#3360

Signed-off-by: ff137 <[email protected]>
Co-authored-by: jamshale <[email protected]>

* fix: check routing keys on endpoint refresh

Previously we were only checking if the endpoint value had changed but
it is possible for the routing keys to update and not the endpoint. This
resulted in new attrib txns not getting published when there were new
routing keys.

Signed-off-by: Daniel Bluhm <[email protected]>

* 1.1.1rc0

Signed-off-by: Stephen Curran <[email protected]>

* Make vc libraries mandatory (openwallet-foundation#3356)

* Make vc libraries mandatory

Signed-off-by: jamshale <[email protected]>

* Make indy-vdr library required

Signed-off-by: jamshale <[email protected]>

* Update dockerfiles after removed extras

Signed-off-by: jamshale <[email protected]>

---------

Signed-off-by: jamshale <[email protected]>

* Update the PR for release

Signed-off-by: Stephen Curran <[email protected]>

* Repair release bdd tests

Signed-off-by: jamshale <[email protected]>

* Add in PR to Changelog

Signed-off-by: Stephen Curran <[email protected]>

* 🎨 Reduce repetition

Signed-off-by: ff137 <[email protected]>

* Fix for demo initial cred_type override (openwallet-foundation#3378)

Signed-off-by: Ian Costanzo <[email protected]>

* chore(deps): Bump dawidd6/action-download-artifact (openwallet-foundation#3370)

Bumps the all-actions group with 1 update: [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact).


Updates `dawidd6/action-download-artifact` from 6 to 7
- [Release notes](https://github.com/dawidd6/action-download-artifact/releases)
- [Commits](dawidd6/action-download-artifact@v6...v7)

---
updated-dependencies:
- dependency-name: dawidd6/action-download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jamshale <[email protected]>

* 🎨 Log warning when StorageNotFoundError encountered, instead of exception stacktrace

Signed-off-by: ff137 <[email protected]>

* 🎨 Set Shutdown log level to fatal, with exc_info

Signed-off-by: ff137 <[email protected]>

* 🎨 Log warning for bad credential format, instead of always exception stacktrace

Signed-off-by: ff137 <[email protected]>

* 🚧 Add exc_info to error log for debugging

Signed-off-by: ff137 <[email protected]>

* 🎨 Make `ensure_supported_did` method public

Signed-off-by: ff137 <[email protected]>

* 🐛 Ensure supported DID before calling Rotate

Resolves: openwallet-foundation#3379
Signed-off-by: ff137 <[email protected]>

* ✅ Fix existing tests

Signed-off-by: ff137 <[email protected]>

* ✅ Test coverage for new DID validation

Signed-off-by: ff137 <[email protected]>

* 🎨 Shorten config key

* 🎨 Fix lying method return type

Signed-off-by: ff137 <[email protected]>

* 🎨 Replace AskarError with ProfileError

Signed-off-by: ff137 <[email protected]>

* 🚧 Skip exception log for ProfileError

Signed-off-by: ff137 <[email protected]>

* 🐛 Fix message type class mapping

Signed-off-by: ff137 <[email protected]>

* 🚧 Debug message parse error

Signed-off-by: ff137 <[email protected]>

* 🚧 Log warning instead of error for MessageParseError

Signed-off-by: ff137 <[email protected]>

* ⬆️ Bump version

Signed-off-by: ff137 <[email protected]>

* ⬆️ Update lock file

Signed-off-by: ff137 <[email protected]>

* 🎨 Fix model name for consistency

From Anoncred to Anoncreds

Signed-off-by: ff137 <[email protected]>

* 🎨 Set wallet upgrade exception log to warning

Signed-off-by: ff137 <[email protected]>

* Update anoncreds format names (openwallet-foundation#3374)

* Update anoncreds format names

Signed-off-by: jamshale <[email protected]>

* Add a unit test

Signed-off-by: jamshale <[email protected]>

---------

Signed-off-by: jamshale <[email protected]>

* 🎨 Fix model name for consistency (openwallet-foundation#3382)

From Anoncred to Anoncreds

Signed-off-by: ff137 <[email protected]>
Co-authored-by: jamshale <[email protected]>

---------

Signed-off-by: ff137 <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Ricky Ng-Adam <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Co-authored-by: Daniel Bluhm <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jamshale <[email protected]>
Co-authored-by: jamshale <[email protected]>
Co-authored-by: Stephen Curran <[email protected]>
Co-authored-by: Emiliano Suñé <[email protected]>
Co-authored-by: Ricky Ng-Adam <[email protected]>
Co-authored-by: Ian Costanzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Improve logging in core components didx-xyz/acapy
4 participants
@rngadam @swcurran @WadeBarnes @jamshale