Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anoncreds Revoking one credential of many of the same type fails proof #2934

Closed
jamshale opened this issue May 7, 2024 · 2 comments
Closed
Assignees
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release AnonCreds Ledger Agnostic AnonCreds

Comments

@jamshale
Copy link
Contributor

jamshale commented May 7, 2024

With anoncreds specifically. If faber issues multiple credentials to alice of the same type and then revokes any of the credentials, the next proof request will fail verification.

Steps (using demo):

  • start faber ./run_demo run faber --wallet-type askar-anoncreds --revocation
  • start alice ./run_demo run alice --wallet-type askar-anoncreds
  • connect
  • issue 3 credentials to alice
  • revoke credential 2
  • request proof
  • result will be verified = false
Screencast.from.2024-05-07.09.39.59.AM.webm
@jamshale jamshale added AnonCreds Ledger Agnostic AnonCreds 1.0.0 To be addressed for the ACA-Py 1.0.0 release labels May 7, 2024
@jamshale jamshale changed the title Revoking one credential of many of the same type fails proof Anoncreds Revoking one credential of many of the same type fails proof May 7, 2024
@swcurran
Copy link
Contributor

swcurran commented May 7, 2024

Sounds like this is either a bug in ACA-Py’s selection of a default credential to use when there are multiple — should choose the most recent non-revoked one, or in Alice picking the wrong one to use from a set.

@swcurran
Copy link
Contributor

swcurran commented May 7, 2024

That said, I don’t know how “default” is defined by ACA-Py. Presumably it is the first in the array of candidate VCs that could be used to satisfy the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release AnonCreds Ledger Agnostic AnonCreds
Projects
None yet
Development

No branches or pull requests

2 participants