Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk container scanning not running on PR #2928

Closed
pradeepp88 opened this issue May 1, 2024 · 7 comments
Closed

Snyk container scanning not running on PR #2928

pradeepp88 opened this issue May 1, 2024 · 7 comments

Comments

@pradeepp88
Copy link
Contributor

pradeepp88 commented May 1, 2024

https://github.com/hyperledger/aries-cloudagent-python/blob/f9d9baded73e49bb796ded1ed9f327dd98ce1c14/.github/workflows/snyk.yml#L1C1-L7C15

Opening this issue to review the Snyk container scan not being run on every PR as configured.

@pradeepp88
Copy link
Contributor Author

@swcurran / @WadeBarnes - can you please check the Snyk account to see if the scans are running there? The Github action shows the last container ran 5 months ago.
image

@WadeBarnes
Copy link
Contributor

It does appear to be running:
image

@pradeepp88
Copy link
Contributor Author

@WadeBarnes thanks for checking. So it is an integration issue with Github to view the results.

Is there a public link to view the Snyk scanning results directly from there?

@WadeBarnes
Copy link
Contributor

@pradeepp88, Submitted a PR here that should fix the Sync Container scanning issues; #2951

@pradeepp88
Copy link
Contributor Author

Thanks @WadeBarnes but still the sarif file is having some config errors and the workflow fails
image

@pradeepp88
Copy link
Contributor Author

@WadeBarnes submitted a PR #2961 to fix this issue.

@jamshale
Copy link
Contributor

jamshale commented Jul 8, 2024

This fix was merged so I believe this issue can be closed.

@jamshale jamshale closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants