-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests creating existing DID's #2855
Comments
have we found in the code where the seed is generated? I was thinking in here but I couldn't see it |
The aca-py seed is created here: https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/runners/support/agent.py#L211 It's kind of hokey and not really robust enough for running integration tests, where we may create hundreds of DID's in a single run of the tests. (It was initially implemented for a simple demo but should be updated ...) |
I can suggest to switch to python secrets.token_urlsafe to create a random seed with large entropy instead of randint. |
I'll take a look, thanks for the suggestion. |
The integration tests are recreating the same did's they previously created causing fails because the schema/cred_def's they are trying to create already exist on the ledger. Should be able to make the seed/did creation more random to prevent this from happening.
The text was updated successfully, but these errors were encountered: