Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA-Py - Credo: didexchange/1.0 vs 1.1 #2742

Closed
dbluhm opened this issue Jan 29, 2024 · 3 comments · Fixed by #2748
Closed

ACA-Py - Credo: didexchange/1.0 vs 1.1 #2742

dbluhm opened this issue Jan 29, 2024 · 3 comments · Fixed by #2748
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release

Comments

@dbluhm
Copy link
Contributor

dbluhm commented Jan 29, 2024

With the recent updates to didexchange adding support for did:peer:2/4, we also added support for the did_rotate~attach attachment. This technically bumps our protocol support up to 1.1. Credo correctly made this version bump which is causing interop issues since we're sending 1.0 and they're expecting 1.1.

The naive fix would be to just find replace 1.0 for 1.1 but that could break other agents we interop with on 1.0. Handling both would be preferable. I personally wouldn't mind too terribly if we gated the did_rotate~attach on version or not.

@swcurran I believe it would be wise for us to make sure this correction makes it into 0.12.0

@swcurran swcurran added the Discuss Issues to be raised for discussion at an ACA-Pug Meeting label Jan 29, 2024
@swcurran
Copy link
Contributor

OK — let’s discuss at our Maintainer’s Meeting tomorrow (2024.01.30).

@swcurran swcurran removed the Discuss Issues to be raised for discussion at an ACA-Pug Meeting label Jan 30, 2024
@andrewwhitehead
Copy link
Contributor

I believe Credo should accept didexchange/1.0 according to DIDComm versioning.

@dbluhm
Copy link
Contributor Author

dbluhm commented Jan 31, 2024

Drawing from https://github.com/hyperledger/aries-rfcs/blob/main/concepts/0003-protocols/README.md#semver-rules-for-protocols

Within a given major version of a protocol, an agent should:

  • Respond to a minimum supported minor version, defaulting to "0".
    • An agent SHOULD keep minimum supported minor version at "0" unless it is unsecure or extremely complicated to do so.
  • Respond with or initiate a protocol instance the current fully supported minor version.

Using did:peer:2 or 4 without did_rotate~attach might be enough to consider it "insecure" and dropping support for 1.0. 🤷‍♂️

@swcurran swcurran added the 1.0.0 To be addressed for the ACA-Py 1.0.0 release label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants