Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the "emit-did-peer..." startup options to be tenant specific #2724

Closed
swcurran opened this issue Jan 18, 2024 · 4 comments · Fixed by #2790
Closed

Enable the "emit-did-peer..." startup options to be tenant specific #2724

swcurran opened this issue Jan 18, 2024 · 4 comments · Fixed by #2790
Assignees
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release

Comments

@swcurran
Copy link
Contributor

We would like to see the new ability to emit DID Peer connections to tenant specific, so that we can experiment with enabling connection reuse.

@swcurran swcurran moved this to Assignment Ready in CDT Enterprise Apps Jan 18, 2024
@swcurran
Copy link
Contributor Author

@esune , @loneil — what is the effort to do this? Are there instructions on how this is done?

@esune
Copy link
Member

esune commented Jan 23, 2024

This PR has the changes that relate to per-tenant settings.
At minimum, we would extend the settings to be included/supported in the list that currently holds which settings can be "tenantized". We could also look at cleaning-up a bit that list (which is actually currently two lists) so that more settings are supported out-of-the-box without changes (probably a slightly bigger change).

@swcurran
Copy link
Contributor Author

So the steps are:

  • update the Multitenancy.md documentation to add the item tot he list
  • update the admin/routes.py to add the item to the two lists

Sound right?

@esune
Copy link
Member

esune commented Jan 30, 2024

Yes, that sounds about right if we just want to add this flag to the list without extra refactoring.

@swcurran swcurran added the 1.0.0 To be addressed for the ACA-Py 1.0.0 release label Feb 1, 2024
@amanji amanji moved this from Assignment Ready to Assigned in CDT Enterprise Apps Feb 9, 2024
@amanji amanji moved this from Assigned to In Progress in CDT Enterprise Apps Feb 15, 2024
@amanji amanji moved this from In Progress to In Review in CDT Enterprise Apps Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants