You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #2530 - how to handle orphaned/abandoned connections.
ConnectionManagerError are raised and generally initialized with a descriptive text (ex. "Connection DID does not match DIDDoc id"). Further into the flow, the handlers catch ConnectionManagerErrors then raise ConnectionProblemReport. However, ConnectionProblemReports require very specific enums to set their problem_code property. If the ConnectionManagerError.error_code (the descriptive string) is used as the ConnectionProblemReport.problem_code the schema validation will fail.
So, long story short, when we think we are raising ConnectionProblemReports and sending them to be handled, they actually are not created/handled because they fail schema validation and are not created. We need to go through these and ensure the errors are passed properly and get handled as expected.
Another part of this is ConnectionProblemReports use AgentMessage as the base class while DIDExchangeProblemReport uses the ProblemReport as a base class. We should be consistent and update ConnectionProblemReport to follow DIDExchangeProblemReport "standard".
The text was updated successfully, but these errors were encountered:
Related to #2530 - how to handle orphaned/abandoned connections.
ConnectionManagerError are raised and generally initialized with a descriptive text (ex. "Connection DID does not match DIDDoc id"). Further into the flow, the handlers catch ConnectionManagerErrors then raise ConnectionProblemReport. However, ConnectionProblemReports require very specific enums to set their
problem_code
property. If the ConnectionManagerError.error_code (the descriptive string) is used as the ConnectionProblemReport.problem_code the schema validation will fail.So, long story short, when we think we are raising ConnectionProblemReports and sending them to be handled, they actually are not created/handled because they fail schema validation and are not created. We need to go through these and ensure the errors are passed properly and get handled as expected.
Another part of this is ConnectionProblemReports use AgentMessage as the base class while DIDExchangeProblemReport uses the ProblemReport as a base class. We should be consistent and update ConnectionProblemReport to follow DIDExchangeProblemReport "standard".
The text was updated successfully, but these errors were encountered: