Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Tenant setting: requests-through-public-did #2572

Closed
thiagoromanos opened this issue Oct 30, 2023 · 5 comments · Fixed by #2790
Closed

Per Tenant setting: requests-through-public-did #2572

thiagoromanos opened this issue Oct 30, 2023 · 5 comments · Fixed by #2790
Assignees
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release

Comments

@thiagoromanos
Copy link
Contributor

Since I can define per tenant the setting public_invites, it would be great that I could also set per tenant the requests-through-public-did (in a case where I have a tenant that wants to receive those public did requests, but all other tenants don't).

@swcurran
Copy link
Contributor

Thanks — this is correct. @esune — is there a pattern/approach for making configuration parameters tenant-specific vs. global?

@esune
Copy link
Member

esune commented Oct 30, 2023

We have implemented an endpoint in a Traction plugin to facilitate setting these at runtime: see this. I believe that anything listed in this map is supported: we started with a subset of all the options that were available as there are several and we were not sure whether this would be useful for us only or others. I think if there are other flags that would be good to have set at a tenant level they just need to be added to that list.

c.c.: @shaangill025 for more insight.

@thiagoromanos
Copy link
Contributor Author

We have implemented an endpoint in a Traction plugin to facilitate setting these at runtime: see this. I believe that anything listed in this map is supported: we started with a subset of all the options that were available as there are several and we were not sure whether this would be useful for us only or others. I think if there are other flags that would be good to have set at a tenant level they just need to be added to that list.

c.c.: @shaangill025 for more insight.

@esune , is there a plan to add this requests-through-public-did flag to that per-tenant list? Don't think that would be a breaking change to aca-py, since the global flag is there since 0.9.0.

@esune
Copy link
Member

esune commented Dec 4, 2023

@esune , is there a plan to add this requests-through-public-did flag to that per-tenant list? Don't think that would be a breaking change to aca-py, since the global flag is there since 0.9.0.

Looping-in @swcurran and @dbluhm for additional opinions. I don't think it is planned, but I don;t see an issue in having that setting be part of the per-tenant customizations.
@thiagoromanos if you have bandwith a PR is always welcome 😉

@swcurran
Copy link
Contributor

swcurran commented Dec 4, 2023

Agree. I’m hoping it is well documented how to make a setting a per tenant setting so that we can easily add new ones that make sense. Agree that this is one.

@swcurran swcurran added the 1.0.0 To be addressed for the ACA-Py 1.0.0 release label Feb 1, 2024
@esune esune moved this to Assigned in CDT Enterprise Apps Feb 9, 2024
@amanji amanji moved this from Assigned to In Progress in CDT Enterprise Apps Feb 15, 2024
@amanji amanji moved this from In Progress to In Review in CDT Enterprise Apps Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants