Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile RUST_LOG field has wrong value #2498

Closed
loneil opened this issue Sep 20, 2023 · 1 comment
Closed

Dockerfile RUST_LOG field has wrong value #2498

loneil opened this issue Sep 20, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@loneil
Copy link
Contributor

loneil commented Sep 20, 2023

I was inquiring about suppressing some askar INFO level logs and after some feedback from Andrew and Wade discovered that setting the RUST_LOG level to warn should do that.

In our ACA-Py deployment I could see this environment variable is set to warning instead. Which doesn't seem to be right.
image

We're not setting this in any Traction deployment vals for what I'm testing it in, so I'm fairly sure it's coming from a mistake in the Dockerfile here.
https://github.com/hyperledger/aries-cloudagent-python/blob/d705ca2fe9132fc5bdc07e427e10f74201bbfac2/docker/Dockerfile#L25

Andrew mentioned that the value could be warn or fine tuned with aries_askar=warn

I tried both of those manually in my env and they both did what I wanted (suppressing all the askar INFO logs about pool connections and session starts etc).
So depends on what is wanted for this Dockerfile, but existing warning is not having intended effect.

(Note: same issue in Indy Dockerfile if that one matters)

@loneil
Copy link
Contributor Author

loneil commented Sep 20, 2023

Note this is also being used in the devcontainer but that is setting it differently
https://github.com/hyperledger/aries-cloudagent-python/blob/d705ca2fe9132fc5bdc07e427e10f74201bbfac2/.devcontainer/devcontainer.json#L47

@WadeBarnes WadeBarnes added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants