Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 / pytest-flake8 with ruff / pytest-ruff #2400

Closed
ff137 opened this issue Aug 6, 2023 · 1 comment · Fixed by #2438
Closed

Replace flake8 / pytest-flake8 with ruff / pytest-ruff #2400

ff137 opened this issue Aug 6, 2023 · 1 comment · Fixed by #2438
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@ff137
Copy link
Contributor

ff137 commented Aug 6, 2023

Flake8 is being surpassed by an extremely fast linter: https://github.com/astral-sh/ruff.
See the readme for speed comparison and testimonials.

This is primarily suggested because pytest-flake8 is no longer maintained, binding aca-py to flake v4 instead of the latest v6.
To shed technical debt, I propose replacing the pytest-flake8 dependency (used in PR tests) with pytest-ruff

@dbluhm
Copy link
Contributor

dbluhm commented Aug 7, 2023

I am generally in favor of a change. I've heard of ruff before but this is the first time I've looked closer; I notice that the version is 0.0.282. That's the only thing that gives me pause; however, it seems to be widely used and well supported. I think I'm in favor 🙂

@dbluhm dbluhm added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants