Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to “bcgovimages” in ACA-Py repo #2118

Closed
swcurran opened this issue Feb 12, 2023 · 1 comment · Fixed by #2700
Closed

Update references to “bcgovimages” in ACA-Py repo #2118

swcurran opened this issue Feb 12, 2023 · 1 comment · Fixed by #2700
Assignees

Comments

@swcurran
Copy link
Contributor

I found the following references that might need to be changed now that we are publishing images to the Hyperledger Container Registry. Not sure what these should be changed to:

../aries-cloudagent-python/demo/docker-agent/Dockerfile.acapy:FROM bcgovimages/aries-cloudagent:py36-1.16-1_1.0.0-rc0
../aries-cloudagent-python/demo/multi-demo/Dockerfile.acapy:FROM bcgovimages/aries-cloudagent:py36-1.16-1_1.0.0-rc0
../aries-cloudagent-python/SupportedRFCs.md:| Docker | ✅ | BC Gov publishes docker images on Docker Hub |

This are probably OK:

../aries-cloudagent-python/DIDResolution.md:FROM bcgovimages/von-image:py36-1.16-0
../aries-cloudagent-python/docker/Dockerfile.demo:FROM bcgovimages/von-image:py36-1.15-1
../aries-cloudagent-python/docker/Dockerfile.run:FROM bcgovimages/von-image:py36-1.15-1

I’m guessing these are fine:

../aries-cloudagent-python/ContainerImagesAndGithubActions.md:hosted through their bcgovimages docker hub account. These images have been
../aries-cloudagent-python/ContainerImagesAndGithubActions.md:- bcgovimages/aries-cloudagent

@WadeBarnes
Copy link
Contributor

Several of the references had already been updated. I reviewed all and updated as needed.

@WadeBarnes WadeBarnes moved this from Assigned to In Review in CDT Enterprise Apps Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants