Connectionless Verification of revoked credential (as well as valid credential) not working as expected when specifying non_revoked interval in present proof request.

[itsdheerajbudhiraja]

After specifying non_revoked in present proof request:

Till aca-py release 0.7.3 - getting verified: true in response irrespective of credential is revoked or not.

With aca-py 0.7.4-rc* - getting verified: false irrespective of credential is revoked or not.

Sample present proof request:

{
	"name": "access",
	"names": null,
	"version": "1.0",
	"nonce": "674647785166691834257572",
	"requested_attributes": {
	  "e642366f-21c9-4163-aae8-3c37b5afd273": {
		"name": "Employee_Name",
		"restrictions": [
		  {
			"issuer_did": "Y9wFFsnqyVV4pvCyaFmASp"
		  }
		]
	  },
	  "c56954b6-3227-441d-a236-49dec8627583": {
		"name": "Employee_ID",
		"restrictions": [
		  {
			"issuer_did": "Y9wFFsnqyVV4pvCyaFmASp"
		  }
		]
	  }
	},
	"requested_predicates": {},
	"non_revoked": {
	  "from": 0,
	  "to": 1655204958
	}
  }

[itsdheerajbudhiraja]

while trying with 0.7.4-rc2, I was getting following error on agent while generating proof request:

UnboundLocalError: local variable 'transport_id' referenced before assignment
2022-06-14 10:23:27,536 aries_cloudagent.admin.server ERROR Handler error with exception: local variable 'transport_id' referenced before assignment
=================
Traceback (most recent call last):
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/admin/server.py", line 159, in ready_middleware
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/admin/server.py", line 196, in debug_middleware
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp_apispec/middlewares.py", line 45, in validation_middleware
    return await handler(request)

[shaangill025]

@itsdheerajbudhiraja Proof verification is working, I tested [ACA-Py main - latest] for non_revoked in proof_request [present-proof v1 and v2, both revoked and non-revoked credential] using connectionless OOB exchange with Askar and Indy wallets. With 0.7.4-rc2 image there was a bug fixed with #1776 which might be causing the issue.

[itsdheerajbudhiraja]

Problem came out to be in aries js framework - Mobile wallet was sending incorrect proof.

On degugging I figured out this error:

2022-06-17 05:54:45,457 aries_cloudagent.indy.sdk.verifier ERROR Presentation on nonce=331551437322774273490016 cannot be validated: Timestamp on sub-proof #0 is missing vs. requested attribute group 3c78eb4f-c2c7-482c-9557-947b758eb318

Seems holder wallet is sending incorrect proof - Some timestamp is missing.

Aca-py code is working fine.

@swcurran @shaangill025

[swcurran]

Good stuff! Thanks for digging in and confirming.

[TimoGlastra]

ACA-Py 0.7.3 (and before? Not sure what the affected versions are) contained a bug where it would mark a proof as verified if it didn't include a proof of non revocation even though the proof request requested a proof of non-revocation.

This has been fixed since and is therefore now breaking.

AFJ 0.1.0 doesn't have support for revocation yet, and that's why it is now failing with ACA-Py 0.7.4-RC. AFJ 0.2.0 will support revocation.

[swcurran]

Thanks for the explanation @TimoGlastra --- makes sense.