Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AATH ACA-Py - ACA-Py DID Exchange tests failing #1803

Closed
swcurran opened this issue Jun 11, 2022 · 6 comments
Closed

AATH ACA-Py - ACA-Py DID Exchange tests failing #1803

swcurran opened this issue Jun 11, 2022 · 6 comments
Assignees

Comments

@swcurran
Copy link
Contributor

For the past 3 days (starting 2022.06.08, give or take), 9 of the AIP10, and 28 of the AIP20 ACA-Py to ACA-Py tests are failing. All seem to be related to the DID Exchange. The error messages and failure steps can be seen here:

Note that links will disappear after 20 days, give or take.

By drilling into the "Categories" from those links, you can see that errors manifest in 2 ways in the AIP10, and 4 ways in the AIP20. However, it's likely they are all from the same source. Examples:

16 of the 28 AIP20 failed tests generate this error message:

AssertionError: FAILED SUB-STEP: And "Bob" receives the invitation
Substep info: Assertion Failed: resp_status 500 is not 200; 'done'
Traceback (of failed substep):
  File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
    match.run(runner.context)
  File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
    self.func(context, *args, **kwargs)
  File "features/steps/0023-did-exchange.py", line 226, in step_impl
    assert resp_status == 200, f"resp_status {resp_status} is not 200; {resp_text}"

  File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
    match.run(runner.context)
  File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
    self.func(context, *args, **kwargs)
  File "features/steps/0160-connection.py", line 394, in step_impl
    """
  File "/usr/local/lib/python3.7/site-packages/behave/runner.py", line 404, in execute_steps
    assert False, message

6 of the 9 AIP10 failed tests generate this error message -- pretty much the same as above.

AssertionError: FAILED SUB-STEP: When "Acme" and "Bob" create a new didexchange connection
Substep info: Assertion Failed: FAILED SUB-STEP: And "Bob" receives the invitation
Substep info: Assertion Failed: resp_status 500 is not 200; 'done'
Traceback (of failed substep):
  File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
    match.run(runner.context)
  File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
    self.func(context, *args, **kwargs)
  File "features/steps/0023-did-exchange.py", line 226, in step_impl
    assert resp_status == 200, f"resp_status {resp_status} is not 200; {resp_text}"

Traceback (of failed substep):
  File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
    match.run(runner.context)
  File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
    self.func(context, *args, **kwargs)
  File "features/steps/0023-did-exchange.py", line 37, in step_impl
    """
  File "/usr/local/lib/python3.7/site-packages/behave/runner.py", line 404, in execute_steps
    assert False, message
@swcurran
Copy link
Contributor Author

@shaangill025 is working on this. @TimoGlastra -- the timing suggests that this could have been triggered by the "Connectionless" PR that was merged at the same time. There were some other PRs merged that same day, but they seem less likely to have caused this. If you can help or have ideas, please check with Shaanjot -- we don't need to duplicate efforts.

@ianco
Copy link
Contributor

ianco commented Jun 11, 2022

This PR is required I believe: openwallet-foundation/owl-agent-test-harness#474

@TimoGlastra
Copy link
Contributor

Yes as @ianco suggests we need #474. Can we merge it and see if this resolves the issue? Happy to take a look if tests are still failing

@swcurran
Copy link
Contributor Author

Will do! Thanks.

@swcurran
Copy link
Contributor Author

swcurran commented Jun 12, 2022

Tested and got the same error. Steps I did:

gh pr checkout 474
./manage rebuild -a acapy-main
./manage run -d acapy-main -t @T001-RFC0025

@swcurran swcurran added the 0.7.4 label Jun 14, 2022
@swcurran
Copy link
Contributor Author

Updated issue resolved this. Merged into AATH and the tests are now passing (at least locally).

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants