Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add aca-py command line option --genesis-file #122

Closed
SmithSamuelM opened this issue Aug 4, 2019 · 3 comments
Closed

Feature: Add aca-py command line option --genesis-file #122

SmithSamuelM opened this issue Aug 4, 2019 · 3 comments

Comments

@SmithSamuelM
Copy link

The current aca-py has two methods for injecting the genesis transactions.

  1. --genesis-transactions
  2. --genesis-url

The first is not a great user experience. The genesis transactions are a newline separated list of JSON data structures; not event a JSON list. This requires escaping to get the transactions to correctly input from a command line shell. A minimal four node set of genesis transactions are still almost 3K Characters.So this is not a reasonable option.

The second option genesis url requires some web server that provides the genesis transactions. This is a reasonable approach from a user experience but does have a hard dependency on a web server.

A practical alternative that has both decent user experience and no external dependencies is to allow a local file path input to provide the genesis transactions.

@swcurran
Copy link
Contributor

swcurran commented Aug 8, 2019

Agree that is a reasonable approach - I thought that was an option.

Can this be used as a temporary workaround? --genesis-transactions "$(cat <genesis-file>)"

@SmithSamuelM
Copy link
Author

I can't find it as an option anywhere so it would be good to add. Thanks. Also good suggestion for workaround.

@andrewwhitehead
Copy link
Contributor

Resolved via PR #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants