Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openwallet-foundation/acapy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10a849c50b5120076b2e977cd4d33314c0591000
Choose a base ref
..
head repository: openwallet-foundation/acapy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d7b69c33d2f9beb4aee9bbb4cff5b4f1b1781038
Choose a head ref
Showing with 7 additions and 6 deletions.
  1. +1 −1 aries_cloudagent/anoncreds/holder.py
  2. +5 −4 aries_cloudagent/indy/models/cred_request.py
  3. +1 −1 demo/features/0454-present-proof.feature
2 changes: 1 addition & 1 deletion aries_cloudagent/anoncreds/holder.py
Original file line number Diff line number Diff line change
@@ -128,7 +128,7 @@ async def create_credential_request(
Args:
credential_offer: The credential offer to create request for
credential_definition: The credential definition to create an offer for
holder_did: the DID of the agent making the request
holder_did: the DID of the agent making the request (may not be a real DID)
Returns:
A tuple of the credential request and credential request metadata
9 changes: 5 additions & 4 deletions aries_cloudagent/indy/models/cred_request.py
Original file line number Diff line number Diff line change
@@ -8,8 +8,7 @@
from ...messaging.valid import (
INDY_CRED_DEF_ID_EXAMPLE,
INDY_CRED_DEF_ID_VALIDATE,
INDY_DID_EXAMPLE,
INDY_DID_VALIDATE,
UUID4_EXAMPLE,
NUM_STR_WHOLE_EXAMPLE,
NUM_STR_WHOLE_VALIDATE,
)
@@ -52,8 +51,10 @@ class Meta:

prover_did = fields.Str(
required=True,
validate=INDY_DID_VALIDATE,
metadata={"description": "Prover DID", "example": INDY_DID_EXAMPLE},
metadata={
"description": "Prover DID/Random String/UUID",
"example": UUID4_EXAMPLE,
},
)
cred_def_id = fields.Str(
required=True,
2 changes: 1 addition & 1 deletion demo/features/0454-present-proof.feature
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ Feature: RFC 0454 Aries agent present proof
| Faber | --public-did | --wallet-type askar-anoncreds | driverslicense_v2 | Data_DL_MaxValues | DL_age_over_19_v2 |


@T001-RFC0454-DID-PEER
@T001-RFC0454-DID-PEER @GHA
Scenario Outline: Present Proof where the prover does not propose a presentation of the proof and is acknowledged
Given we have "2" agents
| name | role | capabilities | extra |