fix: convert any usage into or typed version #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
requested review from
lukasjhan and
zustkeeper
as code owners
Signed-off-by: Berend Sliedrecht <[email protected]>
|
@berendsliedrecht build is failing, do you need help with this?: https://github.com/openwallet-foundation-labs/sd-jwt-js/actions/runs/8003556836/job/21859109338?pr=80#step:7:146 |
Signed-off-by: Berend Sliedrecht <[email protected]>
|
@cre8 Should be fixed now. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 65.50% 65.62% +0.11%
==========================================
Files 33 33
Lines 2102 2115 +13
Branches 233 234 +1
==========================================
+ Hits 1377 1388 +11
- Misses 706 708 +2
Partials 19 19 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 22, 2024
Merged
cre8
pushed a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Berend Sliedrecht <[email protected]> Co-authored-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
cre8
pushed a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Berend Sliedrecht <[email protected]> Co-authored-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted most any usage to unknown. Not the best fix in the world, but to make it fully properly typed I need some more time.