Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align media type with sd-jwt-vc draft 06 #256

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

charsleysa
Copy link
Contributor

@cre8
Copy link
Contributor

cre8 commented Nov 15, 2024

@charsleysa thanks for the PR!

@lukasjhan I would be fine with this change without marking it as a breaking change. The sd-jwt vc spec is still in draft

Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@lukasjhan
Copy link
Member

@cre8 I'm also fine with this change :). Let's merge it

@lukasjhan lukasjhan merged commit 1aa3aea into openwallet-foundation:main Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants